You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/01/28 19:12:19 UTC
[GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/251
header-control-bar: fix select-all-state
When I select all documents
And there are less documents than I have set to display per page
Then I want the select-all-button to be selected/disabled
As I checked for the setting of the page compared to the selected
documents it can happen that if we have not enough documents to
show on the page that the status of the select-all was wrong.
Added test to avoid regressions in the future and to prove my fix
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton fix-header-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/251.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #251
----
commit 3889357cb9e88bcf428285cd843bbb5bafb20da1
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-01-28T18:08:53Z
header-control-bar: fix select-all-state
When I select all documents
And there are less documents than I have set to display per page
Then I want the select-all-button to be selected/disabled
As I checked for the setting of the page compared to the selected
documents it can happen that if we have not enough documents to
show on the page that the status of the select-all was wrong.
Added test to avoid regressions in the future and to prove my fix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
Posted by michellephung <gi...@git.apache.org>.
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/251#issuecomment-71894768
+1
To test:
On master, if you have database with 8 documents, and show 5 documents at a time, view the second page (doc 6-8), and hit 'select all', notice that the 'select all' and 'unselect all' are both grayed out.
When on pr/251, this doesn't happen.
On another note: the highlight select states are a bit confusing.
I realize that a highlight state in the UI means that that current button is being shown, but a greyed out button makes me think that a button is disabled, not that that it is a selectable button. The only thing I can think of that won't involve more colors or lot of ui changes would be to change the color on hover. Any thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/251#issuecomment-72013790
merged as 18bd88f2fcea4d3aa83a8b55b62a6d9f2763feee
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: header-control-bar: fix select-all-s...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/251#issuecomment-72013524
@michellephung let's talk together with sean next standup regardign the colors!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---