[GitHub] [trafficcontrol] rob05c opened a new pull request, #6994: Fix Health Client nil panic on blank parent.config lines

[GitBox <gi...@apache.org>]

rob05c opened a new pull request, #6994:
URL: https://github.com/apache/trafficcontrol/pull/6994

   Fixes the Health Client to not panic and crash if parent.config has a blank line. The current `t3c` will always insert a blank line after the header comment, to make it possible to programmatically distinguish the header comment from line comments. Thus, the Health Client will always crash with a parent.config generated by `t3c` from the same latest Traffic Control version.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Health Client (tc-health-client)
   
   ## What is the best way to verify this PR?
   Run the Health Client with a parent.config with any blank line in it.
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - 6.1.0
   - 7.0.0 (RC2)
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - ~[x] This PR has documentation~ no docs, no interface change <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #6994: Fix Health Client nil panic on blank parent.config lines

[GitBox <gi...@apache.org>]

zrhoffman merged PR #6994:
URL: https://github.com/apache/trafficcontrol/pull/6994


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org