[GitHub] [ozone] GeorgeJahad commented on pull request #3746: HDDS-7121. Support namespace summaries (du, dist & counts) for legacy FS buckets

[GitBox <gi...@apache.org>]

GeorgeJahad commented on PR #3746:
URL: https://github.com/apache/ozone/pull/3746#issuecomment-1248697782

   So there is a problem with clearing the NSSummary table during reprocess().
   
   Both the fso and legacy tasks write to the nssummary table. The reprocess() method for FSO clears the nssummary table [here](https://github.com/apache/ozone/blob/39c0c25c07e359a1e5f0968a2143db1dc9da3c19/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/NSSummaryTaskWithFSO.java#L176) The Legacy task doesn't clear the table.
   
   But both tasks run in separate threads in [parallel](https://github.com/apache/ozone/blob/39c0c25c07e359a1e5f0968a2143db1dc9da3c19/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java#L172-L179)  There is no guarantee that FSO will run first.
   
   In addition failed tasks get rerun [here](https://github.com/apache/ozone/blob/39c0c25c07e359a1e5f0968a2143db1dc9da3c19/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ReconTaskControllerImpl.java#L120-L131)  If one fails and the other doesn't the delete won't work correctly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org