[GitHub] spark pull request #17175: [SPARK-19931][SQL] InMemoryTableScanExec should r...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17175#discussion_r105588650
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala ---
    @@ -42,10 +42,34 @@ case class InMemoryTableScanExec(
       override def output: Seq[Attribute] = attributes
     
       // The cached version does not change the outputPartitioning of the original SparkPlan.
    -  override def outputPartitioning: Partitioning = relation.child.outputPartitioning
    +  // But the cached version could alias output, so we need to replace output.
    +  override def outputPartitioning: Partitioning = {
    +    val attrMap = AttributeMap(
    +      relation.child.output.zip(output)
    +    )
    +    relation.child.outputPartitioning match {
    +      case HashPartitioning(expressions, numPartitions) =>
    --- End diff --
    
    `HashPartitioning` is an expression, we can simplify it to
    ```
    case h: HashPartitioning => h transformExpression {
        ...
      }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org