[GitHub] srowen commented on a change in pull request #23785: [SPARK-26860][PySpark] Fix for RangeBetween docs appear to be wrong

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23785: [SPARK-26860][PySpark] Fix for RangeBetween docs appear to be wrong
URL: https://github.com/apache/spark/pull/23785#discussion_r256968310
 
 

 ##########
 File path: python/pyspark/sql/window.py
 ##########
 @@ -89,6 +89,9 @@ def rowsBetween(start, end):
         Creates a :class:`WindowSpec` with the frame boundaries defined,
         from `start` (inclusive) to `end` (inclusive).
 
+        Rows Between cares only about the order of rows, and takes fixed number of
 
 Review comment:
   "Rows Between" -> "rowsBetween"? but I'm also not quite sure what this means. Ordering matters and yes it seems kind of implied that the number is fixed? what's a 'frame'?
   
   Is there Scala doc that can be copied instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org