[jira] [Commented] (HBASE-11901) Improve the value size of the reference cell in mob column

["Anoop Sam John (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122354#comment-14122354 ] 

Anoop Sam John commented on HBASE-11901:
----------------------------------------

Looks fine

{code}
   public Cell resolve(Cell reference, boolean cacheBlocks) throws IOException {
     Cell result = null;
-    if (reference.getValueLength() > Bytes.SIZEOF_LONG) {
+    if (reference.getValueLength() > Bytes.SIZEOF_INT) {
{code}
We will write the value size always. We really need this if check?

> Improve the value size of the reference cell in mob column
> ----------------------------------------------------------
>
>                 Key: HBASE-11901
>                 URL: https://issues.apache.org/jira/browse/HBASE-11901
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: hbase-11339
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>             Fix For: hbase-11339
>
>         Attachments: HBASE-11901.diff
>
>
>  Now in the value of a reference cell in a mob column, it's realMobValueLength(Use a long type currently) + mobFileName.
>  Actually the value length in cell is a int type, it's not necessary to use a long here. In the improvement, we'll use the int type instead long in a reference mob value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)