You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by clebertsuconic <gi...@git.apache.org> on 2017/04/07 01:45:56 UTC
[GitHub] activemq-artemis pull request #1183: ARTEMIS-1089 Improving flow control on ...
GitHub user clebertsuconic opened a pull request:
https://github.com/apache/activemq-artemis/pull/1183
ARTEMIS-1089 Improving flow control on replication
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clebertsuconic/activemq-artemis replication
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1183.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1183
----
commit 911888e8d19c98400a68f969b1c8f86bff51fa17
Author: Clebert Suconic <cl...@apache.org>
Date: 2017-04-06T15:47:31Z
ARTEMIS-1089 Improving flow control on replication
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #1183: ARTEMIS-1089 Improving flow control on replica...
Posted by franz1981 <gi...@git.apache.org>.
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1183
I've a similar issue to solve [ARTEMIS-1098](https://issues.apache.org/jira/browse/ARTEMIS-1098) but I'm trying to understand where is the best point where put the (connection) flow control management.
For my use case it could be:
1. "hidden" in the [ChannelImpl::send](https://github.com/apache/activemq-artemis/blob/177480d8684fe0ecffa597878e07fb17ffcb5b8c/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ChannelImpl.java#L306) for not batched writes (this will impact the streaming of large message AFAIK but maybe others use cases)
2. implement a new method ChannelImpl::sendControlled (or similar) that will perform flow controlled sends and will be called (right now) only by [ActiveMQSessionContext::sendLargeMessageChunk](https://github.com/apache/activemq-artemis/blob/177480d8684fe0ecffa597878e07fb17ffcb5b8c/artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java#L468) to reduce the impact on other use cases
I'm not seeing (right now) other ways to do it, but I want to be consistent to what you've done here: do you have any suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #1183: ARTEMIS-1089 Improving flow control on ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---