You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/20 14:59:41 UTC
[PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
alamb opened a new pull request, #16485:
URL: https://github.com/apache/datafusion/pull/16485
This reverts commit a0eaf5107cc4f8093378a4547b7a12c63a275171.
## Which issue does this PR close?
- related to https://github.com/apache/datafusion/issues/16452
## Rationale for this change
- We thought we fixed the test with the intermittent failures on main. so we started running the tests again https://github.com/apache/datafusion/pull/16470
However, then the test failed again when we re-enabled it:
https://github.com/apache/datafusion/actions/runs/15780623790/job/44485106315
Let's revert the revert
## What changes are included in this PR?
Re-disable the test on main while we sort out the root cause
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992097384
We could also set `enable_dynamic_filter_pushdown` to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992681735
I think it is a good idea to revert #15770 on a branch, run tests for a few rounds on CI and see if the PR is the offending PR. If so, we can then revert it on main as we search for the root cause inside the changes #15770, which will significantly narrow down the possible causes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2993554314
I think it was after and I had made some edits to try to locate the section of code producing the but. But the comment was just to make the point of how flakey this is. Let's continue discussion in https://github.com/apache/datafusion/issues/16452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992148994
Basically from what I can tell we don't really know what the root cause is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2993026589
```
Results:
Total runs: 497
Failures: 1
Passes: 496
Failure rate: 0.20%
```
ðŸ˜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992975535
> Second local run I got 4/100 failures. What a flake.
😱
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992148020
> Oh boy. @alamb should we revert #15770 altogether then? Does this test not run until it's merged into main / why want's it flagged as part of that PR?
I don't think we should revert the PR given there is a way to turn it off -- let's just keep debugging on main. I'll try and find time over the weekend / next week if it is still unsolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992698066
I'm trying to reproduce locally first by running it 100 times and recording failure rate. I just ran it and got 0 failures. Not sure if this is expected or not. I'll push a branch to CI and try to get it to fail -> commit the revert -> no failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992700750
Second local run I got 4/100 failures. What a flake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2993449122
Is this before the suspect PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992140607
> We could also set `enable_dynamic_filter_pushdown` to false by default?
Does that solve the issue? It didn't seem to in the last thread we had on it. If it does yes I think that's better than reverting the PR. Maybe we should do that out of caution regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2992084389
Oh boy. @alamb should we revert https://github.com/apache/datafusion/pull/15770 altogether then? Does this test not run until it's merged into main / why want's it flagged as part of that PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #16485:
URL: https://github.com/apache/datafusion/pull/16485#issuecomment-2991944321
Thanks @blaginin I am merging this in to get main back clean again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Reapply "Ignore `sort_query_fuzzer_runner` (#16462)" (#16470) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #16485:
URL: https://github.com/apache/datafusion/pull/16485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org