You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2019/04/14 16:44:00 UTC
PrepareLocalesForDropDown.groovy
Hi,
PrepareLocalesForDropDown.groovy is not used at all OOTB
Should we not remove it?
Jacques
Re: PrepareLocalesForDropDown.groovy
Posted by Michael Brohl <mi...@ecomify.de>.
If functionality is in the codebase it might be used even if it is not
used in the standard processes/functionality.
Better discuss than revert, I'd say.
I see no problem here.
Thanks,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 16.04.19 um 08:37 schrieb Pierre Smits:
> Why is this even a discussion topic? Are we not going overboard here with
> having to discuss everything and thus stifling furthering the code and the
> project?
>
> We should not keep stuff in the code base that is not used in production
> implementations and/or for development.
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Tue, Apr 16, 2019 at 8:30 AM Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Thanks Nicolas,
>>
>> Removed at revision: 1857622
>>
>> Jacques
>>
>> Le 15/04/2019 à 15:49, Nicolas Malin a écrit :
>>> :) ok for me just go out
>>>
>>> Nicolas
>>>
>>> On 14/04/2019 20:42, Jacques Le Roux wrote:
>>>> This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
>>>>
>>>> Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
>>>>> Hello
>>>>>
>>>>> poveglia$ svn up
>>>>>
>>>>> Actualisé à la révision 1857522.
>>>>> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
>>>>> poveglia$
>>>>>
>>>>> What this file ?
>>>>>
>>>>> Nicolas
>>>>>
>>>>> On 14/04/2019 18:44, Jacques Le Roux wrote:
>>>>>> Hi,
>>>>>>
>>>>>> PrepareLocalesForDropDown.groovy is not used at all OOTB
>>>>>>
>>>>>> Should we not remove it?
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
Re: PrepareLocalesForDropDown.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
To reassure you: I had a look at log history before removing it. It was part of the Sascha's Apache Jackrabbit effort 7 years ago. Jackrabbit was
never adopted: https://issues.apache.org/jira/browse/OFBIZ-4659
Jacques
Le 16/04/2019 à 10:07, Olivier Heintz a écrit :
> One of Example Component goal is to have some example of code or manner to do.
>
> So, code present in example not using in a production environment is not a argument to say we should remove it or not.
>
> If this code could be use in a localized OFBiz, we should retain it.
>
> My 2 cent.
> Olivier
>
>
> Le 16/04/2019 à 08:37, Pierre Smits a écrit :
>> Why is this even a discussion topic? Are we not going overboard here with
>> having to discuss everything and thus stifling furthering the code and the
>> project?
>>
>> We should not keep stuff in the code base that is not used in production
>> implementations and/or for development.
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
>> *Apache Directory <https://directory.apache.org>, PMC Member*
>> Apache Incubator <https://incubator.apache.org>, committer
>> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
>> since 2008*
>> Apache Steve <https://steve.apache.org>, committer
>>
>>
>> On Tue, Apr 16, 2019 at 8:30 AM Jacques Le Roux <
>> jacques.le.roux@les7arts.com> wrote:
>>
>>> Thanks Nicolas,
>>>
>>> Removed at revision: 1857622
>>>
>>> Jacques
>>>
>>> Le 15/04/2019 à 15:49, Nicolas Malin a écrit :
>>>> :) ok for me just go out
>>>>
>>>> Nicolas
>>>>
>>>> On 14/04/2019 20:42, Jacques Le Roux wrote:
>>>>> This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
>>>>>
>>>>> Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
>>>>>> Hello
>>>>>>
>>>>>> poveglia$ svn up
>>>>>>
>>>>>> Actualisé à la révision 1857522.
>>>>>> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
>>>>>> poveglia$
>>>>>>
>>>>>> What this file ?
>>>>>>
>>>>>> Nicolas
>>>>>>
>>>>>> On 14/04/2019 18:44, Jacques Le Roux wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> PrepareLocalesForDropDown.groovy is not used at all OOTB
>>>>>>>
>>>>>>> Should we not remove it?
>>>>>>>
>>>>>>> Jacques
>>>>>>>
>>>>>>>
Re: PrepareLocalesForDropDown.groovy
Posted by Olivier Heintz <ol...@ofbizextra.org>.
One of Example Component goal is to have some example of code or manner to do.
So, code present in example not using in a production environment is not a argument to say we should remove it or not.
If this code could be use in a localized OFBiz, we should retain it.
My 2 cent.
Olivier
Le 16/04/2019 à 08:37, Pierre Smits a écrit :
> Why is this even a discussion topic? Are we not going overboard here with
> having to discuss everything and thus stifling furthering the code and the
> project?
>
> We should not keep stuff in the code base that is not used in production
> implementations and/or for development.
>
> Best regards,
>
> Pierre Smits
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> *Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
> since 2008*
> Apache Steve <https://steve.apache.org>, committer
>
>
> On Tue, Apr 16, 2019 at 8:30 AM Jacques Le Roux <
> jacques.le.roux@les7arts.com> wrote:
>
>> Thanks Nicolas,
>>
>> Removed at revision: 1857622
>>
>> Jacques
>>
>> Le 15/04/2019 à 15:49, Nicolas Malin a écrit :
>>> :) ok for me just go out
>>>
>>> Nicolas
>>>
>>> On 14/04/2019 20:42, Jacques Le Roux wrote:
>>>> This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
>>>>
>>>> Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
>>>>> Hello
>>>>>
>>>>> poveglia$ svn up
>>>>>
>>>>> Actualisé à la révision 1857522.
>>>>> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
>>>>> poveglia$
>>>>>
>>>>> What this file ?
>>>>>
>>>>> Nicolas
>>>>>
>>>>> On 14/04/2019 18:44, Jacques Le Roux wrote:
>>>>>> Hi,
>>>>>>
>>>>>> PrepareLocalesForDropDown.groovy is not used at all OOTB
>>>>>>
>>>>>> Should we not remove it?
>>>>>>
>>>>>> Jacques
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
Re: PrepareLocalesForDropDown.groovy
Posted by Pierre Smits <pi...@apache.org>.
Why is this even a discussion topic? Are we not going overboard here with
having to discuss everything and thus stifling furthering the code and the
project?
We should not keep stuff in the code base that is not used in production
implementations and/or for development.
Best regards,
Pierre Smits
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
*Apache OFBiz <https://ofbiz.apache.org>, contributor (without privileges)
since 2008*
Apache Steve <https://steve.apache.org>, committer
On Tue, Apr 16, 2019 at 8:30 AM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Thanks Nicolas,
>
> Removed at revision: 1857622
>
> Jacques
>
> Le 15/04/2019 à 15:49, Nicolas Malin a écrit :
> > :) ok for me just go out
> >
> > Nicolas
> >
> > On 14/04/2019 20:42, Jacques Le Roux wrote:
> >> This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
> >>
> >> Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
> >>> Hello
> >>>
> >>> poveglia$ svn up
> >>>
> >>> Actualisé à la révision 1857522.
> >>> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
> >>> poveglia$
> >>>
> >>> What this file ?
> >>>
> >>> Nicolas
> >>>
> >>> On 14/04/2019 18:44, Jacques Le Roux wrote:
> >>>> Hi,
> >>>>
> >>>> PrepareLocalesForDropDown.groovy is not used at all OOTB
> >>>>
> >>>> Should we not remove it?
> >>>>
> >>>> Jacques
> >>>>
> >>>>
> >>>
> >>
> >
>
Re: PrepareLocalesForDropDown.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
Thanks Nicolas,
Removed at revision: 1857622
Jacques
Le 15/04/2019 à 15:49, Nicolas Malin a écrit :
> :) ok for me just go out
>
> Nicolas
>
> On 14/04/2019 20:42, Jacques Le Roux wrote:
>> This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
>>
>> Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
>>> Hello
>>>
>>> poveglia$ svn up
>>>
>>> Actualisé à la révision 1857522.
>>> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
>>> poveglia$
>>>
>>> What this file ?
>>>
>>> Nicolas
>>>
>>> On 14/04/2019 18:44, Jacques Le Roux wrote:
>>>> Hi,
>>>>
>>>> PrepareLocalesForDropDown.groovy is not used at all OOTB
>>>>
>>>> Should we not remove it?
>>>>
>>>> Jacques
>>>>
>>>>
>>>
>>
>
Re: PrepareLocalesForDropDown.groovy
Posted by Nicolas Malin <ni...@nereide.fr>.
:) ok for me just go out
Nicolas
On 14/04/2019 20:42, Jacques Le Roux wrote:
> This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
>
> Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
>> Hello
>>
>> poveglia$ svn up
>>
>> Actualisé à la révision 1857522.
>> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
>> poveglia$
>>
>> What this file ?
>>
>> Nicolas
>>
>> On 14/04/2019 18:44, Jacques Le Roux wrote:
>>> Hi,
>>>
>>> PrepareLocalesForDropDown.groovy is not used at all OOTB
>>>
>>> Should we not remove it?
>>>
>>> Jacques
>>>
>>>
>>
>
Re: PrepareLocalesForDropDown.groovy
Posted by Jacques Le Roux <ja...@les7arts.com>.
This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy
Le 14/04/2019 à 19:01, Nicolas Malin a écrit :
> Hello
>
> poveglia$ svn up
>
> Actualisé à la révision 1857522.
> poveglia$ find . -iname PrepareLocalesForDropDown.groovy
> poveglia$
>
> What this file ?
>
> Nicolas
>
> On 14/04/2019 18:44, Jacques Le Roux wrote:
>> Hi,
>>
>> PrepareLocalesForDropDown.groovy is not used at all OOTB
>>
>> Should we not remove it?
>>
>> Jacques
>>
>>
>
Re: PrepareLocalesForDropDown.groovy
Posted by Nicolas Malin <ni...@nereide.fr>.
Hello
poveglia$ svn up
Actualisé à la révision 1857522.
poveglia$ find . -iname PrepareLocalesForDropDown.groovy
poveglia$
What this file ?
Nicolas
On 14/04/2019 18:44, Jacques Le Roux wrote:
> Hi,
>
> PrepareLocalesForDropDown.groovy is not used at all OOTB
>
> Should we not remove it?
>
> Jacques
>
>