You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/02 20:46:26 UTC

[GitHub] [superset] rusackas commented on a diff in pull request #19540: fix: View Results Doesn't Match Chart After Refreshing Cache

rusackas commented on code in PR #19540:
URL: https://github.com/apache/superset/pull/19540#discussion_r863177725


##########
superset-frontend/src/explore/components/DataTablesPane/index.tsx:
##########
@@ -242,9 +255,13 @@ export const DataTablesPane = ({
         ...prevIsLoading,
         [resultType]: true,
       }));
+
+      chartUpdateCacheInvalidationStatus(false);
+
       return getChartDataRequest({
         formData: queryFormData,
         resultFormat: 'json',
+        force: !!latestQueryCacheInvalidatedRef.current,
         resultType,
         ownState,
       })

Review Comment:
   @zhaoyongjie were you indeed opening a PR to resolve this, or just providing some advice/examples?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org