You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/04/17 18:13:11 UTC

[GitHub] lucperkins commented on issue #1587: [WIP] Add key/value operations in StateContext

lucperkins commented on issue #1587: [WIP] Add key/value operations in StateContext
URL: https://github.com/apache/incubator-pulsar/pull/1587#issuecomment-382090215
 
 
   I'd also recommend using `Optional` instead of allowing for `null` on methods like `getValue`. `CompletableFuture<Optional<ByteBuffer>>` is admittedly somewhat verbose but it does have the virtue of preventing a lot of `null`-related headaches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services