You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/05/18 19:00:05 UTC

[GitHub] [kafka] guozhangwang commented on pull request #12121: KAFKA-13846: Adding overloaded metricOrElseCreate method

guozhangwang commented on PR #12121:
URL: https://github.com/apache/kafka/pull/12121#issuecomment-1130394986

   > From a public API point of view, Metrics is in a gray area. It is not officially part of our public API however we have a few interfaces leaking it. That being said, we should be careful with the changes that we do here.
   
   I agree with @dajac  as well, what I was thinking is that we can modify the private `registerMetric`, and I'm neutral about whether adding a public `metricOrElseCreate` should require a KIP. If people think this is necessary, we could create one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org