[GitHub] agrawaldevesh commented on issue #6831: Do label name mutation before anything else on the dataframe

[GitBox <gi...@apache.org>]

agrawaldevesh commented on issue #6831: Do label name mutation before anything else on the dataframe
URL: https://github.com/apache/incubator-superset/pull/6831#issuecomment-461722338
 
 
   Thanks Ville ! Go for it. I am not in a hurry and would rather do this
   properly. Please prepare the PR or tell me your thoughts and I can prepare
   one :)
   
   On Thu, Feb 7, 2019 at 11:59 PM Ville Brofeldt <no...@github.com>
   wrote:
   
   > I have an idea of how one could simplify and merge the old logic with the
   > new one (the new df mutator is already in master). I can put in a PR for
   > that, after which this PR would only need to be rebased.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-superset/pull/6831#issuecomment-461720718>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ATnI_y5wOaowuTDrq9oo1Opnxosrt1vvks5vLS5ygaJpZM4ammk7>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org