You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by al...@apache.org on 2018/02/07 18:40:49 UTC

[camel] branch master updated: CAMEL-12235: Completed unit tests

This is an automated email from the ASF dual-hosted git repository.

aldettinger pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git


The following commit(s) were added to refs/heads/master by this push:
     new e96cc3c  CAMEL-12235: Completed unit tests
e96cc3c is described below

commit e96cc3c9847c8e0f13bdeb1a431553a89c0db239
Author: aldettinger <al...@gmail.com>
AuthorDate: Wed Feb 7 19:28:13 2018 +0100

    CAMEL-12235: Completed unit tests
---
 .../component/kafka/KafkaConsumerFullTest.java     |  1 -
 .../kafka/KafkaConsumerLastRecordHeaderTest.java   |  1 -
 .../camel/component/kafka/KafkaEndpointTest.java   | 53 ++++++++++++++++------
 3 files changed, 38 insertions(+), 17 deletions(-)

diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerFullTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerFullTest.java
index 34333f8..d9be4d6 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerFullTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerFullTest.java
@@ -24,7 +24,6 @@ import org.apache.camel.Endpoint;
 import org.apache.camel.EndpointInject;
 import org.apache.camel.builder.RouteBuilder;
 import org.apache.camel.component.mock.MockEndpoint;
-import org.apache.kafka.clients.producer.ProducerConfig;
 import org.apache.kafka.clients.producer.ProducerRecord;
 import org.junit.After;
 import org.junit.Before;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerLastRecordHeaderTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerLastRecordHeaderTest.java
index e17c03d..ffa0d22 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerLastRecordHeaderTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaConsumerLastRecordHeaderTest.java
@@ -23,7 +23,6 @@ import org.apache.camel.EndpointInject;
 import org.apache.camel.Exchange;
 import org.apache.camel.builder.RouteBuilder;
 import org.apache.camel.component.mock.MockEndpoint;
-import org.apache.kafka.clients.producer.ProducerConfig;
 import org.apache.kafka.clients.producer.ProducerRecord;
 import org.junit.After;
 import org.junit.Before;
diff --git a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaEndpointTest.java b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaEndpointTest.java
index f968932..5400e1a 100644
--- a/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaEndpointTest.java
+++ b/components/camel-kafka/src/test/java/org/apache/camel/component/kafka/KafkaEndpointTest.java
@@ -16,36 +16,59 @@
  */
 package org.apache.camel.component.kafka;
 
-import java.net.URISyntaxException;
-
 import org.apache.camel.Exchange;
+import org.apache.camel.Message;
 import org.apache.camel.impl.DefaultCamelContext;
 import org.apache.kafka.clients.consumer.ConsumerRecord;
+import org.junit.Before;
 import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnitRunner;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.when;
 
+@RunWith(MockitoJUnitRunner.class)
 public class KafkaEndpointTest {
 
+    private KafkaEndpoint endpoint;
+
+    @Mock
+    private ConsumerRecord<String, String> mockRecord;
+
+    @Mock
+    private KafkaComponent mockKafkaComponent;
+
+    @Before
+    public void setup() {
+        endpoint = new KafkaEndpoint("kafka:mytopic?brokers=localhost", new KafkaComponent(new DefaultCamelContext()));
+    }
+
     @Test
-    public void testCreatingKafkaExchangeSetsHeaders() throws URISyntaxException {
-        KafkaEndpoint endpoint = new KafkaEndpoint("kafka:mytopic?brokers=localhost", new KafkaComponent(new DefaultCamelContext()));
-
-        ConsumerRecord<String, String> record = new ConsumerRecord<String, String>("topic", 4, 56, "somekey", "");
-        Exchange exchange = endpoint.createKafkaExchange(record);
-        assertEquals("somekey", exchange.getIn().getHeader(KafkaConstants.KEY));
-        assertEquals("topic", exchange.getIn().getHeader(KafkaConstants.TOPIC));
-        assertEquals(4, exchange.getIn().getHeader(KafkaConstants.PARTITION));
-        assertEquals(56L, exchange.getIn().getHeader(KafkaConstants.OFFSET));
+    public void createKafkaExchangeShouldSetHeaders() {
+
+        when(mockRecord.key()).thenReturn("somekey");
+        when(mockRecord.topic()).thenReturn("topic");
+        when(mockRecord.partition()).thenReturn(4);
+        when(mockRecord.offset()).thenReturn(56L);
+        when(mockRecord.timestamp()).thenReturn(1518026587392L);
+
+        Exchange exchange = endpoint.createKafkaExchange(mockRecord);
+        Message inMessage = exchange.getIn();
+        assertNotNull(inMessage);
+        assertEquals("somekey", inMessage.getHeader(KafkaConstants.KEY));
+        assertEquals("topic", inMessage.getHeader(KafkaConstants.TOPIC));
+        assertEquals(4, inMessage.getHeader(KafkaConstants.PARTITION));
+        assertEquals(56L, inMessage.getHeader(KafkaConstants.OFFSET));
+        assertEquals(1518026587392L, inMessage.getHeader(KafkaConstants.TIMESTAMP));
     }
 
     @Test
-    public void assertSingleton() throws URISyntaxException {
-        KafkaEndpoint endpoint = new KafkaEndpoint("kafka:mytopic?brokers=localhost", new KafkaComponent(new DefaultCamelContext()));
-        endpoint.getConfiguration().setBrokers("localhost");
+    public void isSingletonShoudlReturnTrue() {
         assertTrue(endpoint.isSingleton());
     }
 
 }
-

-- 
To stop receiving notification emails like this one, please contact
aldettinger@apache.org.