You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/05/18 15:17:46 UTC
[GitHub] dewrich closed pull request #2292: adds orderby=name query param
when fetching profiles
dewrich closed pull request #2292: adds orderby=name query param when fetching profiles
URL: https://github.com/apache/incubator-trafficcontrol/pull/2292
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js b/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
index 377c93477..e6065bd79 100644
--- a/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
+++ b/traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
@@ -27,7 +27,7 @@ var FormDeliveryServiceController = function(deliveryService, dsCurrent, type, t
};
var getProfiles = function() {
- profileService.getProfiles()
+ profileService.getProfiles({ orderby: 'name' })
.then(function(result) {
$scope.profiles = _.filter(result, function(profile) {
return profile.type == 'DS_PROFILE';
diff --git a/traffic_portal/app/src/common/modules/table/parameterProfiles/TableParameterProfilesController.js b/traffic_portal/app/src/common/modules/table/parameterProfiles/TableParameterProfilesController.js
index bf31fd2a7..f4502737a 100644
--- a/traffic_portal/app/src/common/modules/table/parameterProfiles/TableParameterProfilesController.js
+++ b/traffic_portal/app/src/common/modules/table/parameterProfiles/TableParameterProfilesController.js
@@ -101,7 +101,7 @@ var TableParameterProfilesController = function(parameter, parameterProfiles, $s
return parameter;
},
allProfiles: function(profileService) {
- return profileService.getProfiles();
+ return profileService.getProfiles({ orderby: 'name' });
},
assignedProfiles: function() {
return parameterProfiles;
diff --git a/traffic_portal/app/src/common/modules/table/profiles/TableProfilesController.js b/traffic_portal/app/src/common/modules/table/profiles/TableProfilesController.js
index 5e398ecd9..5b1b17eb4 100644
--- a/traffic_portal/app/src/common/modules/table/profiles/TableProfilesController.js
+++ b/traffic_portal/app/src/common/modules/table/profiles/TableProfilesController.js
@@ -65,7 +65,7 @@ var TableProfilesController = function(profiles, $scope, $state, $location, $uib
return params;
},
collection: function(profileService) {
- return profileService.getProfiles();
+ return profileService.getProfiles({ orderby: 'name' });
}
}
});
diff --git a/traffic_portal/app/src/modules/private/cdns/profiles/index.js b/traffic_portal/app/src/modules/private/cdns/profiles/index.js
index 0cdf3b61d..89f964085 100644
--- a/traffic_portal/app/src/modules/private/cdns/profiles/index.js
+++ b/traffic_portal/app/src/modules/private/cdns/profiles/index.js
@@ -31,7 +31,7 @@ module.exports = angular.module('trafficPortal.private.cdns.profiles', [])
return cdnService.getCDN($stateParams.cdnId);
},
profiles: function($stateParams, profileService) {
- return profileService.getProfiles({ cdn: $stateParams.cdnId });
+ return profileService.getProfiles({ cdn: $stateParams.cdnId, orderby: 'name' });
}
}
}
diff --git a/traffic_portal/app/src/modules/private/profiles/list/index.js b/traffic_portal/app/src/modules/private/profiles/list/index.js
index ae04e6cd5..4486c9b94 100644
--- a/traffic_portal/app/src/modules/private/profiles/list/index.js
+++ b/traffic_portal/app/src/modules/private/profiles/list/index.js
@@ -28,7 +28,7 @@ module.exports = angular.module('trafficPortal.private.profiles.list', [])
controller: 'TableProfilesController',
resolve: {
profiles: function(profileService) {
- return profileService.getProfiles();
+ return profileService.getProfiles({ orderby: 'name' });
}
}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services