You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Ryan Baxter <rb...@gmail.com> on 2012/05/01 22:11:15 UTC
Re: Review Request: Add registerConextListener API for embedded experiences
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4898/
-----------------------------------------------------------
(Updated 2012-05-01 20:11:15.214794)
Review request for shindig.
Changes
-------
Minor tweaks, making code a bit cleaner.
Summary
-------
These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.
http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences
http://code.google.com/p/opensocial-resources/issues/detail?id=1249
This addresses bug SHINDIG-1760.
https://issues.apache.org/jira/browse/SHINDIG-1760
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670
Diff: https://reviews.apache.org/r/4898/diff
Testing
-------
Tested with sample gadgets in the embedded experiences container.
Thanks,
Ryan
Re: Review Request: Add registerConextListener API for embedded experiences
Posted by Ryan Baxter <rb...@gmail.com>.
> On 2012-05-02 11:40:58, Stanton Sievers wrote:
> > LGTM
Committed
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4898/#review7464
-----------------------------------------------------------
On 2012-05-01 20:11:15, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4898/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 20:11:15)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.
>
>
> http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences
>
> http://code.google.com/p/opensocial-resources/issues/detail?id=1249
>
>
> This addresses bug SHINDIG-1760.
> https://issues.apache.org/jira/browse/SHINDIG-1760
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670
>
> Diff: https://reviews.apache.org/r/4898/diff
>
>
> Testing
> -------
>
> Tested with sample gadgets in the embedded experiences container.
>
>
> Thanks,
>
> Ryan
>
>
Re: Review Request: Add registerConextListener API for embedded experiences
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4898/#review7464
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-05-01 20:11:15, Ryan Baxter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4898/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 20:11:15)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> These changes are needed to align with the OpenSocial 2.5 proposal to create an API allowing gadgets to register for a listener to receive the embedded experiences context.
>
>
> http://docs.opensocial.org/display/OSD/Convenience+APIs+For+Embedded+Experiences
>
> http://code.google.com/p/opensocial-resources/issues/detail?id=1249
>
>
> This addresses bug SHINDIG-1760.
> https://issues.apache.org/jira/browse/SHINDIG-1760
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml 1332670
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1332670
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js 1332670
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/embeddedexperiences/feature.xml 1332670
>
> Diff: https://reviews.apache.org/r/4898/diff
>
>
> Testing
> -------
>
> Tested with sample gadgets in the embedded experiences container.
>
>
> Thanks,
>
> Ryan
>
>