[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #619: DISPATCH-1480: properly settle messages received by the edge address …

[GitBox <gi...@apache.org>]

kgiusti commented on a change in pull request #619: DISPATCH-1480: properly settle messages received by the edge address …
URL: https://github.com/apache/qpid-dispatch/pull/619#discussion_r346856732
 
 

 ##########
 File path: src/router_core/modules/edge_router/addr_proxy.c
 ##########
 @@ -460,8 +461,14 @@ static void on_transfer(void           *link_context,
 
         qd_parse_free(body);
         qd_iterator_free(iter);
+    } else {
+        qd_log(ap->core->log, QD_LOG_WARNING,
+               "Edge Address Proxy: received an invalid message body, rejecting");
+        dispo = PN_REJECTED;
     }
 
+    qdrc_endpoint_settle_CT(ap->core, dlv, dispo);
 
 Review comment:
   No invalid messages were involved.   All deliveries that end up received by this endpoint client simply were never settled.  
   I'm not aware of any instance where invalid messages have been received by this code, however I want to add the extra logging IF at some point the code breaks and actually generates an invalid message.
   
   However I think you raise a good point:  It would be best to make sure the sender can recover if a PN_REJECTED outcome is returned.  Let me check that before this patch lands.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org