You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2020/08/30 07:56:57 UTC

[Bug 64696] New: Freestyle format for names in (Default)SamplerCreater

https://bz.apache.org/bugzilla/show_bug.cgi?id=64696

            Bug ID: 64696
           Summary: Freestyle format for names in (Default)SamplerCreater
           Product: JMeter
           Version: Nightly (Please specify date)
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: felix.schumacher@internetallee.de
  Target Milestone: JMETER_5.3.1

The generated names for Samplers from the https recorder should be chosen more
freely. Currently the only formats available are prefix or transaction name
which can be combined with a system property to number them.

PR 571 (https://github.com/apache/jmeter/pull/571) describes the wished
features.
To be even more free in the structure of the generated names, the feature has
been implemented in PR 595.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64696] Freestyle format for names in (Default)SamplerCreater

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64696

--- Comment #2 from Felix Schumacher <fe...@internetallee.de> ---
commit af8c10529cd086f013e2a2081aae2ca85888c739
Author: Felix Schumacher <fe...@internetallee.de>
AuthorDate: Mon Aug 31 18:31:42 2020 +0200

    Freestyle format for names in (Default)SamplerCreator

    Use a default value for the format string, that can be controlled by
    a JMeter property.

    Bugzilla Id: 64696
    Relates to #595
---
 bin/jmeter.properties                              |  3 +++
 .../jmeter/protocol/http/proxy/ProxyControl.java   | 23 +++++++++++++---------
 .../protocol/http/proxy/gui/ProxyControlGui.java   |  2 ++
 xdocs/usermanual/properties_reference.xml          |  5 +++++
 4 files changed, 24 insertions(+), 9 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64696] Freestyle format for names in (Default)SamplerCreater

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64696

--- Comment #3 from Felix Schumacher <fe...@internetallee.de> ---
commit d59da3805edd0b2fc901e404bddf9de6d6051bc2
AuthorDate: Mon Aug 31 21:11:50 2020 +0200

    Freestyle format for names in (Default)SamplerCreator

    Don't save the default value for the format string property

    Bugzilla Id: 64696
    Relates to #595
---
 .../org/apache/jmeter/protocol/http/proxy/ProxyControl.java  | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64696] Freestyle format for names in (Default)SamplerCreater

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64696

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Felix Schumacher <fe...@internetallee.de> ---
commit b69ca04a1be2d20d21d83278dc951ab52c9751d3
Author: Felix Schumacher <fe...@internetallee.de>
AuthorDate: Sun May 31 16:03:41 2020 +0200

    Freestyle format for names in (Default)SamplerCreater

    Names of newly created Samplers by the DefaultSamplerCreator can now be
    styled with a freestyle format, that understands the controls for
    MessageFormat. Apart from the placeholders {0}, {1} and {2}, that are
    hard to guess, for which part they are used, more memorizable placeholders
     #{name}, #{path} and #{counter} can be used.

    The counter for the generated samplers can be set to a user specified
number.

    Based on a patch by Vincent Daburon

    Bugzilla Id: 64696
    Closes #571
    Closes #595
---
 .../apache/jmeter/resources/messages.properties    |   6 +
 .../apache/jmeter/resources/messages_fr.properties |   6 +
 .../http/proxy/AbstractSamplerCreator.java         |   5 +
 .../protocol/http/proxy/DefaultSamplerCreator.java |  64 +++++---
 .../jmeter/protocol/http/proxy/HttpRequestHdr.java |  12 +-
 .../apache/jmeter/protocol/http/proxy/Proxy.java   |  12 +-
 .../jmeter/protocol/http/proxy/ProxyControl.java   |  13 +-
 .../jmeter/protocol/http/proxy/SamplerCreator.java |   8 +
 .../protocol/http/proxy/SamplerCreatorFactory.java |  13 ++
 .../protocol/http/proxy/gui/ProxyControlGui.java   | 161 ++++++++++-----------
 .../protocol/http/proxy/gui/RecorderDialog.java    |  62 ++++----
 xdocs/changes.xml                                  |   1 +
 xdocs/images/screenshots/proxy_control.png         | Bin 9505 -> 20741 bytes
 xdocs/usermanual/component_reference.xml           |   5 +-
 14 files changed, 227 insertions(+), 141 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 64696] Freestyle format for names in (Default)SamplerCreater

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64696

--- Comment #4 from Felix Schumacher <fe...@internetallee.de> ---
commit c280cf351938899cbe996ef6563dbeca0940f90f
Author: Felix Schumacher <fe...@internetallee.de>
AuthorDate: Tue Sep 1 14:56:47 2020 +0200

    Freestyle format for names in (Default)SamplerCreator

    Initialize format string correctly when script recorder is
    created by hand instead of with a template.

    Bugzilla Id: 64696
    Relates to #595
---
 .../org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java  | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.