You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/10/18 09:19:07 UTC

[GitHub] [hbase] virajjasani commented on a change in pull request #2557: HBASE-25195 [branch-1] getNumOpenConnections is not effective

virajjasani commented on a change in pull request #2557:
URL: https://github.com/apache/hbase/pull/2557#discussion_r507056870



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerWrapperImpl.java
##########
@@ -68,7 +68,7 @@ public int getNumOpenConnections() {
     if (!isServerStarted() || this.server.connectionList == null) {

Review comment:
       We can also remove `this.server.connectionList == null` because it is not relevant anymore (also, it can never be null)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org