You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/29 21:41:06 UTC
[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #11497: Revert #11335 to prevent chart overwritten by other users
graceguo-supercat opened a new pull request #11497:
URL: https://github.com/apache/incubator-superset/pull/11497
Please see issue reported by #11490.
Reverts apache/incubator-superset#11335
@etr2460 @nytai @ktmud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] craig-rueda merged pull request #11497: fix: Revert #11335 to prevent chart overwritten by other users
Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #11497:
URL: https://github.com/apache/incubator-superset/pull/11497
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #11497: fix: Revert #11335 to prevent chart overwritten by other users
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #11497:
URL: https://github.com/apache/incubator-superset/pull/11497#issuecomment-719052642
I vote we merge the revert as soon as CI passes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on pull request #11497: fix: Revert #11335 to prevent chart overwritten by other users
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #11497:
URL: https://github.com/apache/incubator-superset/pull/11497#issuecomment-719053482
I would encourage everyone to do more local testing before stamping a PR.
You can easily checkout a PR with the Github CLI: https://github.com/cli/cli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11497: fix: Revert #11335 to prevent chart overwritten by other users
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11497:
URL: https://github.com/apache/incubator-superset/pull/11497#issuecomment-719053482
I would encourage everyone to do more of local testing before stamping a PR.
You can easily checkout a PR with the Github CLI: https://github.com/cli/cli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org