You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/11 05:57:26 UTC
[GitHub] [doris] XieJiann commented on a diff in pull request #15775: [feature](Nereids): Add `SQL_MODE`: `PIPES_AS_CONCAT`
XieJiann commented on code in PR #15775:
URL: https://github.com/apache/doris/pull/15775#discussion_r1066598064
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -807,6 +830,19 @@ public Expression visitDate_sub(Date_subContext ctx) {
+ ", supported time unit: YEAR/MONTH/DAY/HOUR/MINUTE/SECOND", ctx);
}
+ @Override
+ public Expression visitDoublePipes(DorisParser.DoublePipesContext ctx) {
+ return ParserUtils.withOrigin(ctx, () -> {
+ Expression left = getExpression(ctx.left);
+ Expression right = getExpression(ctx.right);
+ if (sessionVariable.getSqlMode() == SqlModeHelper.MODE_PIPES_AS_CONCAT) {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org