You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by geomacy <gi...@git.apache.org> on 2016/07/09 13:23:59 UTC

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

GitHub user geomacy opened a pull request:

    https://github.com/apache/brooklyn-server/pull/244

    Update Karaf logging configuration.

    Updates org.ops4j.pax.logging.cfg to be configured similarly to the logback.xml configuration with regular launcher.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/geomacy/brooklyn-server karaf-logging

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/244.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #244
    
----
commit 61a5989c053f3263a2fd64cb82bda2c2cdc4f13b
Author: Geoff Macartney <ge...@cloudsoftcorp.com>
Date:   2016-07-09T13:10:18Z

    Update Karaf logging configuration.
    
    Updates org.ops4j.pax.logging.cfg to be configured similarly to the logback.xml configuration with regular launcher.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171780
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    --- End diff --
    
    Also set `log4j.logger.io.cloudsoft.winrm4j.winrm.WinRmTool=DEBUG` (as is done in `logback-logger-excludes.xml` - that is a very strange place to set the logging to debug!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187458
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    --- End diff --
    
    We'll already have the o.a.b WinRmTool at debug. The reason I say about the io.cloudsoft class is becaues that is the existing logback configuration: https://github.com/apache/brooklyn-server/blob/master/logging/logback-includes/src/main/resources/brooklyn/logback-logger-excludes.xml#L71


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-server/pull/244


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171942
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    +log4j.logger.org.apache.http.impl.client=WARN
    +log4j.logger.javax.management.remote=WARN
    +log4j.logger.com.wordnik.swagger=WARN
    +log4j.logger.org.mongodb.driver=WARN
    +log4j.logger.org.apache.brooklyn.location.jclouds.JcloudsPropertiesFromBrooklynProperties=WARN
    --- End diff --
    
    although INFO might be better 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/244
  
    LGTM; merging now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on the issue:

    https://github.com/apache/brooklyn-server/pull/244
  
    Changes made and squashed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171757
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    --- End diff --
    
    I think we do want this. In https://github.com/apache/brooklyn-server/blob/rel/apache-brooklyn-0.9.0/logging/logback-includes/src/main/resources/brooklyn/logback-logger-excludes.xml#L40-L43, it sets it to only be written to the file. Is it possible to do anything like that here? Could we perhaps have a different log level specifically for the `log4j.appender.out`?
    
    Same for org.apache.http.impl.client: in the logback config, it is written only to the file (rather than setting it to warn).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187456
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    +log4j.logger.org.apache.http.impl.client=WARN
    +log4j.logger.javax.management.remote=WARN
    +log4j.logger.com.wordnik.swagger=WARN
    +log4j.logger.org.mongodb.driver=WARN
    +log4j.logger.org.apache.brooklyn.location.jclouds.JcloudsPropertiesFromBrooklynProperties=WARN
    --- End diff --
    
    OK - I'll add that - I guess could change the code to live TRACE rather than remove the line altogether. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171658
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    --- End diff --
    
    1MB seems very small. It was 100MB in logback: https://github.com/apache/brooklyn-server/blob/rel/apache-brooklyn-0.9.0/logging/logback-includes/src/main/resources/brooklyn/logback-appender-file.xml#L60-L62


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server issue #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/244
  
    Thanks @geomacy - only a few minor comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171937
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    +log4j.logger.org.apache.http.impl.client=WARN
    +log4j.logger.javax.management.remote=WARN
    +log4j.logger.com.wordnik.swagger=WARN
    +log4j.logger.org.mongodb.driver=WARN
    +log4j.logger.org.apache.brooklyn.location.jclouds.JcloudsPropertiesFromBrooklynProperties=WARN
    --- End diff --
    
    When I started Brooklyn up and pointed a web server at it, but didn't actually do anything, I got bunches of log lines from that class every few seconds, not really telling me anything but filling up the logs, e.g.
    
    JcloudsPropertiesFromBrooklynProperties.getProviderName NOT changing provider from openstack-nova to candidate bluebox
    
    This setting will avoid the logs filling up with these messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187541
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    --- End diff --
    
    I think it's right - we are using the apache 2 licensed java winrm library at `io.cloudsoft.winrm4j`. I presume the debug logging that it writes out was deemed useful (in the same way as we find the jclouds debug logging is useful).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70172236
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
    --- End diff --
    
    ah! good point - cut-n-paste...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187477
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    --- End diff --
    
    Yes I'm just wondering if that's right, or something mistakenly added to Brooklyn?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70172222
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
    --- End diff --
    
    Can we remove the "Licensed to Apache" header from the AMP files please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187506
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
    --- End diff --
    
    @geomacy Not sure why this comment is in the brooklyn repo - I thought I made the comment in a private AMP repo on a different PR?! Deleting these comments as they have nothing to do with this brooklyn code/PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187421
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    +log4j.logger.org.apache.http.impl.client=WARN
    +log4j.logger.javax.management.remote=WARN
    +log4j.logger.com.wordnik.swagger=WARN
    +log4j.logger.org.mongodb.driver=WARN
    +log4j.logger.org.apache.brooklyn.location.jclouds.JcloudsPropertiesFromBrooklynProperties=WARN
    --- End diff --
    
    Feels like we should fix the code doing the logging, rather than treating that brooklyn class as a special case of not being logged at debug.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171761
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    +log4j.logger.org.apache.http.impl.client=WARN
    +log4j.logger.javax.management.remote=WARN
    +log4j.logger.com.wordnik.swagger=WARN
    +log4j.logger.org.mongodb.driver=WARN
    +log4j.logger.org.apache.brooklyn.location.jclouds.JcloudsPropertiesFromBrooklynProperties=WARN
    --- End diff --
    
    Why set `JcloudsPropertiesFromBrooklynProperties ` to warn?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70171892
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    +
    +# If you're just going to have a few debug categories these are recommended;
    +# comment out the loggers above and leave these as-is
    +log4.logger.brooklyn.SSH=DEBUG
    +log4.logger.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.brooklyn.util.internal.ssh=DEBUG
    +log4.logger.org.apache.brooklyn.SSH=DEBUG
    +log4.logger.org.apache.brooklyn.location.basic.jclouds=DEBUG
    +log4.logger.org.apache.brooklyn.util.internal.ssh=DEBUG
    +
    +
    +# some loggers are very noisy however, exclude them, or make them file only
    +log4j.logger.org.apache.cxf=ERROR
    +log4j.logger.net.schmizz=WARN
    +log4j.logger.org.eclipse.jetty=WARN
    +log4j.logger.org.reflections.Reflections=WARN
    +log4j.logger.com.sun.jersey.server.impl.application=WARN
    +log4j.logger.org.apache.whirr.service.ComputeCache=WARN
    +log4j.logger.jclouds.ssh=WARN
    --- End diff --
    
    Both the loggers here are file loggers, there's no console output - I thought this might be a good default, but I shall copy the comment about "a bit noisy at info" and leave them at info level, then users looking at this file will be able to conveniently turn them off if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70172108
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    --- End diff --
    
    Should that not be org.apache.brooklyn.util.core.internal.winrm.WinRmTool in Brooklyn?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-server pull request #244: Update Karaf logging configuration.

Posted by geomacy <gi...@git.apache.org>.
Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/244#discussion_r70187550
  
    --- Diff: karaf/apache-brooklyn/src/main/resources/etc/org.ops4j.pax.logging.cfg ---
    @@ -18,29 +18,74 @@
     ################################################################################
     
     # Root logger
    -log4j.rootLogger=INFO, out, osgi:VmLogAppender
    +log4j.rootLogger=INFO, out, debugFile, osgi:VmLogAppender
     log4j.throwableRenderer=org.apache.log4j.OsgiThrowableRenderer
     
     # CONSOLE appender not used by default
     log4j.appender.stdout=org.apache.log4j.ConsoleAppender
     log4j.appender.stdout.layout=org.apache.log4j.PatternLayout
    -log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    +log4j.appender.stdout.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     
    -# File appender
    +# Info file appender
     log4j.appender.out=org.apache.log4j.RollingFileAppender
     log4j.appender.out.layout=org.apache.log4j.PatternLayout
    -log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32C %4L | %X{bundle.id} - %X{bundle.name} - %X{bundle.version} | %m%n
    -log4j.appender.out.file=${karaf.home}/log/brooklyn.log
    +log4j.appender.out.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.out.file=${karaf.home}/log/brooklyn.info.log
    +log4j.appender.out.Threshold=INFO
     log4j.appender.out.append=true
     log4j.appender.out.maxFileSize=1MB
     log4j.appender.out.maxBackupIndex=10
     
    +# Debug file appender
    +log4j.appender.debugFile=org.apache.log4j.RollingFileAppender
    +log4j.appender.debugFile.layout=org.apache.log4j.PatternLayout
    +log4j.appender.debugFile.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
    +log4j.appender.debugFile.file=${karaf.home}/log/brooklyn.debug.log
    +log4j.appender.debugFile.append=true
    +log4j.appender.debugFile.maxFileSize=1MB
    +log4j.appender.debugFile.maxBackupIndex=10
    +
     # Sift appender
     log4j.appender.sift=org.apache.log4j.sift.MDCSiftingAppender
     log4j.appender.sift.key=bundle.name
     log4j.appender.sift.default=brooklyn
     log4j.appender.sift.appender=org.apache.log4j.FileAppender
     log4j.appender.sift.appender.layout=org.apache.log4j.PatternLayout
    -log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} | %-5.5p | %-16.16t | %-32.32c{1} | %-32.32C %4L | %m%n
    +log4j.appender.sift.appender.layout.ConversionPattern=%d{ABSOLUTE} %-5.5p %3.3X{bundle.id} %-30.30c{2} [%-16.16t] %m%n
     log4j.appender.sift.appender.file=${karaf.data}/log/$\\{bundle.name\\}.log
    -log4j.appender.sift.appender.append=true
    \ No newline at end of file
    +log4j.appender.sift.appender.append=true
    +
    +
    +# Logger configuration
    +
    +# The following properties turn on quite verbose DEBUG logging for Brooklyn-relevant loggers
    +log4j.logger.brooklyn=DEBUG
    +log4j.logger.org.apache.brooklyn=DEBUG
    +log4j.logger.org.jclouds=DEBUG
    +log4j.logger.jclouds=DEBUG
    --- End diff --
    
    Grand will add that here too then.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---