You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "TSultanov (via GitHub)" <gi...@apache.org> on 2023/04/12 14:07:58 UTC
[GitHub] [beam] TSultanov opened a new pull request, #26235: [Playground] Make fields categories and context_line optional in examples tag
TSultanov opened a new pull request, #26235:
URL: https://github.com/apache/beam/pull/26235
- Make fields categories and context_line optional in examples tag
- Resolve bug with incorrectly calculated context line after tag is removed from an example
- Resolve bug with an incorrectly reported context line for an example in catalog
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #26235: [Playground] Make fields categories and context_line optional in examples tag
Posted by "alexeyinkin (via GitHub)" <gi...@apache.org>.
alexeyinkin commented on code in PR #26235:
URL: https://github.com/apache/beam/pull/26235#discussion_r1164204092
##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -40,7 +40,7 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
Categories: []string{"MOCK_CAT_1", "MOCK_CAT_2", "MOCK_CAT_3"},
PipelineOptions: "MOCK_OPTIONS",
Review Comment:
This will also help because the current value fails to be parsed and so the example is not runnable.
```suggestion
PipelineOptions: "--name1 value1 --name2 value2",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26235: [Playground] Make fields "categories" and "context_line" optional in examples tags
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26235:
URL: https://github.com/apache/beam/pull/26235#issuecomment-1512803604
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26235: [Playground] Make fields "categories" and "context_line" optional in examples tags
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26235:
URL: https://github.com/apache/beam/pull/26235#issuecomment-1527476869
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TSultanov commented on a diff in pull request #26235: [Playground] Make fields categories and context_line optional in examples tag
Posted by "TSultanov (via GitHub)" <gi...@apache.org>.
TSultanov commented on code in PR #26235:
URL: https://github.com/apache/beam/pull/26235#discussion_r1164219229
##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -40,7 +40,7 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
Categories: []string{"MOCK_CAT_1", "MOCK_CAT_2", "MOCK_CAT_3"},
PipelineOptions: "MOCK_OPTIONS",
Review Comment:
This is internal data used only for test, the mock data used for local deployment is loaded form different place. I'm not if such change will be within the scope of this PR
##########
playground/backend/internal/db/mapper/precompiled_object_mapper_test.go:
##########
@@ -40,7 +40,7 @@ func TestPrecompiledObjectMapper_ToObjectInfo(t *testing.T) {
Categories: []string{"MOCK_CAT_1", "MOCK_CAT_2", "MOCK_CAT_3"},
PipelineOptions: "MOCK_OPTIONS",
Review Comment:
This data used only for this test, the mock data used for local deployment is loaded form different place. I'm not if such change will be within the scope of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #26235: [Playground] Make fields "categories" and "context_line" optional in examples tags
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #26235:
URL: https://github.com/apache/beam/pull/26235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org