You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/05/29 20:36:48 UTC
Review Request 67363: Switched test devices for the `linux/devices`
isolator tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Jie Yu.
Bugs: MESOS-8958
https://issues.apache.org/jira/browse/MESOS-8958
Repository: mesos
Description
-------
The `cpuid` device is not always available when running tests
in a VM, so switch to `/dev/net/tun`. For the purposes of this
test, is doesn't matter what the device is as long as it is
in a subdirectory.
Diffs
-----
src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
Diff: https://reviews.apache.org/r/67363/diff/1/
Testing
-------
sudo make check (Fedora 27)
Thanks,
James Peach
Re: Review Request 67363: Switched test devices for the
`linux/devices` isolator tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204019
-----------------------------------------------------------
PASS: Mesos patch 67363 was successfully built and tested.
Reviews applied: `['67362', '67363']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67363
- Mesos Reviewbot Windows
On May 29, 2018, 8:36 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 8:36 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
>
>
> Diff: https://reviews.apache.org/r/67363/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67363: Switched test devices for the
`linux/devices` isolator tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204024
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67362, 67363]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 29, 2018, 1:36 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 1:36 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
>
>
> Diff: https://reviews.apache.org/r/67363/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 67363: Switched test devices for the
`linux/devices` isolator tests.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67363/#review204012
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 29, 2018, 8:36 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67363/
> -----------------------------------------------------------
>
> (Updated May 29, 2018, 8:36 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Jie Yu.
>
>
> Bugs: MESOS-8958
> https://issues.apache.org/jira/browse/MESOS-8958
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `cpuid` device is not always available when running tests
> in a VM, so switch to `/dev/net/tun`. For the purposes of this
> test, is doesn't matter what the device is as long as it is
> in a subdirectory.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_devices_isolator_tests.cpp efaa43b8b7b7c73c35d995bfbb81fcd620143ea1
>
>
> Diff: https://reviews.apache.org/r/67363/diff/1/
>
>
> Testing
> -------
>
> sudo make check (Fedora 27)
>
>
> Thanks,
>
> James Peach
>
>