You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/10/28 23:42:14 UTC

[GitHub] [druid] gianm opened a new pull request, #13282: MSQ: Fix task lock checking during publish, fix lock priority.

gianm opened a new pull request, #13282:
URL: https://github.com/apache/druid/pull/13282

   Fixes two issues:
   
   1) ControllerImpl did not properly check the return value of
      SegmentTransactionalInsertAction when doing a REPLACE. This could cause
      it to not realize that its locks were preempted.
   
   2) Task lock priority was the default of 0. It should be the higher
      batch default of 50. The low priority made it possible for MSQ tasks
      to be preempted by compaction tasks, which is not desired.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] gianm commented on a diff in pull request #13282: MSQ: Fix task lock checking during publish, fix lock priority.

Posted by GitBox <gi...@apache.org>.
gianm commented on code in PR #13282:
URL: https://github.com/apache/druid/pull/13282#discussion_r1013007429


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -204,6 +204,12 @@ public void stopGracefully(final TaskConfig taskConfig)
     }
   }
 
+  @Override
+  public int getPriority()
+  {
+    return getContextValue(Tasks.PRIORITY_KEY, Tasks.DEFAULT_BATCH_INDEX_TASK_PRIORITY);

Review Comment:
   👍  updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] cryptoe commented on pull request #13282: MSQ: Fix task lock checking during publish, fix lock priority.

Posted by GitBox <gi...@apache.org>.
cryptoe commented on PR #13282:
URL: https://github.com/apache/druid/pull/13282#issuecomment-1306594364

   LGTM thanks @gianm 🚀 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] cryptoe merged pull request #13282: MSQ: Fix task lock checking during publish, fix lock priority.

Posted by GitBox <gi...@apache.org>.
cryptoe merged PR #13282:
URL: https://github.com/apache/druid/pull/13282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org

[GitHub] [druid] cryptoe commented on a diff in pull request #13282: MSQ: Fix task lock checking during publish, fix lock priority.

Posted by GitBox <gi...@apache.org>.
cryptoe commented on code in PR #13282:
URL: https://github.com/apache/druid/pull/13282#discussion_r1008698587


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java:
##########
@@ -204,6 +204,12 @@ public void stopGracefully(final TaskConfig taskConfig)
     }
   }
 
+  @Override
+  public int getPriority()
+  {
+    return getContextValue(Tasks.PRIORITY_KEY, Tasks.DEFAULT_BATCH_INDEX_TASK_PRIORITY);

Review Comment:
   Nit: should we document this here https://druid.apache.org/docs/24.0.0/ingestion/tasks.html#lock-priority ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org