You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/07/03 16:58:00 UTC

[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations

    [ https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151063#comment-17151063 ] 

ASF GitHub Bot commented on GEODE-7670:
---------------------------------------

jujoramos commented on pull request #4848:
URL: https://github.com/apache/geode/pull/4848#issuecomment-653622985


   @agingade 
   
   I've updated the `PR` with the changes you suggested (add `bucketRegion.lockRVVForBulkOp()` and `bucketRegion.unlockRVVForBulkOp()` to `PutAllPRMessage.doLocalPutAll`). I've also modified the test to correctly compare the RVVs from the buckets.
   I'm still seeing some random failures when comparing (primary vs secondary) the `values` and `versions` stored within the `Bucket`, specially whenever the `clear` is executed concurrently with `putAll`.
   That said, I'd suggest to move your suggestions (`bucketRegion.lockRVVForBulkOp()` and `bucketRegion.unlockRVVForBulkOp()`) to a new ticket and only use this `PR` for the actual distributed test.
   Please let me know what you think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Partitioned Region clear operations can occur during concurrent data operations
> -------------------------------------------------------------------------------
>
>                 Key: GEODE-7670
>                 URL: https://issues.apache.org/jira/browse/GEODE-7670
>             Project: Geode
>          Issue Type: Sub-task
>          Components: regions
>            Reporter: Nabarun Nag
>            Assignee: Juan Ramos
>            Priority: Major
>              Labels: GeodeCommons
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Clear operations are successful when concurrent read/write operations occur. Ensure there are test coverage for this use case and modify the code needed to enable this.
> Acceptance :
>  * Passing DUnit tests where clear operations are successful on partitioned region with 
>  * concurrent puts (writes) and clear op
>  * concurrent gets (reads) and clear op
>  * Test coverage to when a member departs in this scenario
>  * Test coverage to when a member restarts in this scenario
>  * Unit tests with complete code coverage for the newly written code.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)