You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "FoghostCn (via GitHub)" <gi...@apache.org> on 2024/01/19 04:22:32 UTC
[PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]
FoghostCn opened a new pull request, #608:
URL: https://github.com/apache/dubbo-go-pixiu/pull/608
dynamic Router and Cluster from registry center
ref #600
config schema changed:
```yaml
adapters:
- id: test
name: dgp.adapter.dubboregistrycenter
config:
cluster: "test-dubbo" // new added config field
registries:
"zookeeper":
protocol: zookeeper
address: "127.0.0.1:2181"
timeout: "5s"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]
Posted by "FoghostCn (via GitHub)" <gi...@apache.org>.
FoghostCn closed pull request #608: dynamic Router and Cluster from registry center
URL: https://github.com/apache/dubbo-go-pixiu/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #608:
URL: https://github.com/apache/dubbo-go-pixiu/pull/608#issuecomment-1899746650
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=608) **Quality Gate passed**
Kudos, no new issues were introduced!
[0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=608&resolved=false&inNewCodePeriod=true)
[0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=608&resolved=false&inNewCodePeriod=true)
No data about Coverage
No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=608)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #608:
URL: https://github.com/apache/dubbo-go-pixiu/pull/608#issuecomment-1962846301
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `8 lines` in your changes are missing coverage. Please review.
> Project coverage is 54.67%. Comparing base [(`be3c95e`)](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/be3c95e07d02376eac9bd300df07d2de5d4d1d51?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`e146718`)](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 4 commits behind head on develop.
| [Files](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...bboregistry/registry/zookeeper/service\_listener.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL2FkYXB0ZXIvZHViYm9yZWdpc3RyeS9yZWdpc3RyeS96b29rZWVwZXIvc2VydmljZV9saXN0ZW5lci5nbw==) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pixiu/pkg/server/api\_config\_manager.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL3NlcnZlci9hcGlfY29uZmlnX21hbmFnZXIuZ28=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pixiu/pkg/server/router\_manager.go](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGl4aXUvcGtnL3NlcnZlci9yb3V0ZXJfbWFuYWdlci5nbw==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #608 +/- ##
===========================================
+ Coverage 54.66% 54.67% +0.01%
===========================================
Files 671 671
Lines 78657 78658 +1
===========================================
+ Hits 42998 43010 +12
+ Misses 31986 31971 -15
- Partials 3673 3677 +4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/608?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] dynamic Router and Cluster from registry center [dubbo-go-pixiu]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #608:
URL: https://github.com/apache/dubbo-go-pixiu/pull/608#issuecomment-2016658261
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=608) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu&pullRequest=608&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu&pullRequest=608&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu&pullRequest=608&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu&pullRequest=608)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org