You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2016/11/28 06:18:18 UTC

Review Request 54109: Changes in Mesos to make http::Request::client optional.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54109/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Changes in Mesos to make http::Request::client optional.


Diffs
-----

  src/master/http.cpp 90cbed1ba411e18906fe9c26bc14576a26d1b7b9 
  src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 

Diff: https://reviews.apache.org/r/54109/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman


Re: Review Request 54109: Changes in Mesos to make http::Request::client optional.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54109/#review157178
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Nov. 28, 2016, 6:18 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54109/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes in Mesos to make http::Request::client optional.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 90cbed1ba411e18906fe9c26bc14576a26d1b7b9 
>   src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f 
> 
> Diff: https://reviews.apache.org/r/54109/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Re: Review Request 54109: Changes in Mesos to make http::Request::client optional.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54109/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 8:23 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Changes in Mesos to make http::Request::client optional.


Diffs (updated)
-----

  src/master/http.cpp 90cbed1ba411e18906fe9c26bc14576a26d1b7b9 
  src/slave/http.cpp 91bb882270a65add754180ff107024257b873642 

Diff: https://reviews.apache.org/r/54109/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman