You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/24 02:43:58 UTC

[jira] [Commented] (EAGLE-671) AlertEngine: incorrect metric system use : too many metric object create and registered

    [ https://issues.apache.org/jira/browse/EAGLE-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15600747#comment-15600747 ] 

ASF GitHub Bot commented on EAGLE-671:
--------------------------------------

GitHub user mizeng opened a pull request:

    https://github.com/apache/incubator-eagle/pull/554

    EAGLE-671: incorrect metric system use : too many metric object creat…

    Currently there're too many metric objects create and registered in AlertBolt. This will impact the performance.
    
    In AlertBolt: we should register one metric to metric system, then use the metric object to send metric. Not every-time register the metric to metric system.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mizeng/incubator-eagle master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #554
    
----
commit 5fd881a2eb7cd5750e1b1c52b12657c24491e77e
Author: mizeng <mi...@ebaysf.com>
Date:   2016-10-24T02:29:03Z

    EAGLE-671: incorrect metric system use : too many metric object create and registered

----


> AlertEngine: incorrect metric system use : too many metric object create and registered
> ---------------------------------------------------------------------------------------
>
>                 Key: EAGLE-671
>                 URL: https://issues.apache.org/jira/browse/EAGLE-671
>             Project: Eagle
>          Issue Type: Task
>    Affects Versions: v0.5.0
>            Reporter: Su Ralph
>            Assignee: Zeng, Bryant
>             Fix For: v0.5.0
>
>
> In AlertBolt: we should register one metric to metric system, then use the metric object to send metric. Not  every-time register the metric to metric systm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)