You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/11/28 15:28:24 UTC
[commons-vfs] branch master updated (2165ba3 -> bd0b64c)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git.
from 2165ba3 Fix Checkstyle HideUtilityClassConstructor.
new 6944df6 Make private final variable static.
new bd0b64c Fix Checkstyle FinalClass and MagicNumber.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/commons/vfs2/provider/zip/ZipFileSystem.java | 2 +-
.../src/main/java/org/apache/commons/vfs2/util/URIBitSets.java | 2 +-
.../src/main/java/org/apache/commons/vfs2/util/URIUtils.java | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
[commons-vfs] 01/02: Make private final variable static.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
commit 6944df67de35c2c5acfea6bb7cb2913620cc9dbd
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 28 10:18:45 2021 -0500
Make private final variable static.
---
.../main/java/org/apache/commons/vfs2/provider/zip/ZipFileSystem.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileSystem.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileSystem.java
index 618baa6..67fcd92 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileSystem.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/zip/ZipFileSystem.java
@@ -43,7 +43,7 @@ import org.apache.commons.vfs2.provider.UriParser;
* A read-only file system for ZIP and JAR files.
*/
public class ZipFileSystem extends AbstractFileSystem {
- private final char[] ENC = {'!'};
+ private static final char[] ENC = {'!'};
private static final Log LOG = LogFactory.getLog(ZipFileSystem.class);
[commons-vfs] 02/02: Fix Checkstyle FinalClass and MagicNumber.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-vfs.git
commit bd0b64cd73cde8ee142b6d3c886e7234dacb0a10
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 28 10:28:21 2021 -0500
Fix Checkstyle FinalClass and MagicNumber.
---
.../src/main/java/org/apache/commons/vfs2/util/URIBitSets.java | 2 +-
.../src/main/java/org/apache/commons/vfs2/util/URIUtils.java | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIBitSets.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIBitSets.java
index f373394..2206922 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIBitSets.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIBitSets.java
@@ -879,7 +879,7 @@ final class URIBitSets {
ALLOWED_FRAGMENT.clear('%');
}
- private static BitSet createBitSet() {
+ static BitSet createBitSet() {
return new BitSet(NBITS);
}
diff --git a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIUtils.java b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIUtils.java
index f177e0a..1df6a9c 100644
--- a/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIUtils.java
+++ b/commons-vfs2/src/main/java/org/apache/commons/vfs2/util/URIUtils.java
@@ -46,7 +46,7 @@ public class URIUtils {
* but it should work with any different HTTP backend provider implementations.
* </p>
*/
- private static class EncodingUtils {
+ private static final class EncodingUtils {
/**
* Converts the byte array of ASCII characters to a string. This method is
@@ -103,11 +103,11 @@ public class URIUtils {
* via Http Client v3 library any more.
* </p>
*/
- private static class URLCodecUtils {
+ private static final class URLCodecUtils {
private static final byte ESCAPE_CHAR = '%';
- private static final BitSet WWW_FORM_URL_SAFE = new BitSet(256);
+ private static final BitSet WWW_FORM_URL_SAFE = URIBitSets.createBitSet();
// Static initializer for www_form_url
static {