[jira] [Commented] (MJAR-208) Make naming of properties consistent

["Anders Hammar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MJAR-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15215732#comment-15215732 ] 

Anders Hammar commented on MJAR-208:
------------------------------------

Does it even make sense to have some of these params configurable via CLI properties? I'd argue that it should be configured in the pom.

> Make naming of properties consistent
> ------------------------------------
>
>                 Key: MJAR-208
>                 URL: https://issues.apache.org/jira/browse/MJAR-208
>             Project: Maven JAR Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>             Fix For: 3.0.0
>
>
> Change the naming of the properties from:
> {code}
>  @Parameter( alias = "jarName", property = "jar.finalName", defaultValue = "${project.build.finalName}" )
>  @Parameter( property = "jar.useDefaultManifestFile", defaultValue = "false" )
>  @Parameter( property = "jar.forceCreation", defaultValue = "false" )
>  @Parameter( property = "jar.skipIfEmpty", defaultValue = "false" )
>  @Parameter( property = "maven.jar.classifier" )
>  @Parameter( property = "maven.test.skip" )
>  @Parameter( property = "maven.jar.testClassifier", defaultValue = "tests" )
> {code}
> into:
> {code}
> @Parameter( property = "maven.jar.finalName", defaultValue = "${project.build.finalName}" )
>  @Parameter( property = "maven.jar.useDefaultManifestFile", defaultValue = "false" )
>  @Parameter( property = "maven.jar.forceCreation", defaultValue = "false" )
>  @Parameter( property = "maven.jar.skipIfEmpty", defaultValue = "false" )
>  @Parameter( property = "maven.jar.classifier" )
>  @Parameter( property = "maven.test.skip" )
>  @Parameter( property = "maven.jar.testClassifier", defaultValue = "tests" )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)