You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/21 14:06:19 UTC
svn commit: r1775425 -
/jmeter/trunk/src/components/org/apache/jmeter/assertions/SizeAssertion.java
Author: pmouawad
Date: Wed Dec 21 14:06:19 2016
New Revision: 1775425
URL: http://svn.apache.org/viewvc?rev=1775425&view=rev
Log:
Sonar : Fix code smells
Modified:
jmeter/trunk/src/components/org/apache/jmeter/assertions/SizeAssertion.java
Modified: jmeter/trunk/src/components/org/apache/jmeter/assertions/SizeAssertion.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/assertions/SizeAssertion.java?rev=1775425&r1=1775424&r2=1775425&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/assertions/SizeAssertion.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/assertions/SizeAssertion.java Wed Dec 21 14:06:19 2016
@@ -74,7 +74,7 @@ public class SizeAssertion extends Abstr
public AssertionResult getResult(SampleResult response) {
AssertionResult result = new AssertionResult(getName());
result.setFailure(false);
- long resultSize=0;
+ long resultSize;
if (isScopeVariable()){
String variableName = getVariableName();
String value = getThreadContext().getVariables().get(variableName);
@@ -178,31 +178,31 @@ public class SizeAssertion extends Abstr
private String compareSize(long resultSize) {
String comparatorErrorMessage;
long allowedSize = Long.parseLong(getAllowedSize());
- boolean result = false;
+ boolean result;
int comp = getCompOper();
switch (comp) {
case EQUAL:
- result = (resultSize == allowedSize);
+ result = resultSize == allowedSize;
comparatorErrorMessage = JMeterUtils.getResString("size_assertion_comparator_error_equal"); //$NON-NLS-1$
break;
case NOTEQUAL:
- result = (resultSize != allowedSize);
+ result = resultSize != allowedSize;
comparatorErrorMessage = JMeterUtils.getResString("size_assertion_comparator_error_notequal"); //$NON-NLS-1$
break;
case GREATERTHAN:
- result = (resultSize > allowedSize);
+ result = resultSize > allowedSize;
comparatorErrorMessage = JMeterUtils.getResString("size_assertion_comparator_error_greater"); //$NON-NLS-1$
break;
case LESSTHAN:
- result = (resultSize < allowedSize);
+ result = resultSize < allowedSize;
comparatorErrorMessage = JMeterUtils.getResString("size_assertion_comparator_error_less"); //$NON-NLS-1$
break;
case GREATERTHANEQUAL:
- result = (resultSize >= allowedSize);
+ result = resultSize >= allowedSize;
comparatorErrorMessage = JMeterUtils.getResString("size_assertion_comparator_error_greaterequal"); //$NON-NLS-1$
break;
case LESSTHANEQUAL:
- result = (resultSize <= allowedSize);
+ result = resultSize <= allowedSize;
comparatorErrorMessage = JMeterUtils.getResString("size_assertion_comparator_error_lessequal"); //$NON-NLS-1$
break;
default: