You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2025/07/28 20:29:51 UTC
[PR] conf_remap: Fix build to add appropriate lib deps [trafficserver]
zwoop opened a new pull request, #12400:
URL: https://github.com/apache/trafficserver/pull/12400
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] conf_remap: Fix build to add appropriate lib deps [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #12400:
URL: https://github.com/apache/trafficserver/pull/12400#discussion_r2237823002
##########
plugins/conf_remap/CMakeLists.txt:
##########
@@ -17,3 +17,5 @@
add_atsplugin(conf_remap conf_remap.cc)
verify_remap_plugin(conf_remap)
+
+target_link_libraries(conf_remap PRIVATE libswoc::libswoc yaml-cpp::yaml-cpp)
Review Comment:
Would be better not to depend on tsutil, but that's out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] conf_remap: Fix build to add appropriate lib deps [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on code in PR #12400:
URL: https://github.com/apache/trafficserver/pull/12400#discussion_r2237819652
##########
plugins/conf_remap/CMakeLists.txt:
##########
@@ -17,3 +17,5 @@
add_atsplugin(conf_remap conf_remap.cc)
verify_remap_plugin(conf_remap)
+
+target_link_libraries(conf_remap PRIVATE libswoc::libswoc yaml-cpp::yaml-cpp)
Review Comment:
It comes from this include
```
#include "tsutil/YamlCfg.h"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] conf_remap: Fix build to add appropriate lib deps [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on code in PR #12400:
URL: https://github.com/apache/trafficserver/pull/12400#discussion_r2237809228
##########
plugins/conf_remap/CMakeLists.txt:
##########
@@ -17,3 +17,5 @@
add_atsplugin(conf_remap conf_remap.cc)
verify_remap_plugin(conf_remap)
+
+target_link_libraries(conf_remap PRIVATE libswoc::libswoc yaml-cpp::yaml-cpp)
Review Comment:
I see that conf_remap uses libswoc, but where is the yaml-cpp dependency coming from?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] conf_remap: Fix build to add appropriate lib deps [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #12400:
URL: https://github.com/apache/trafficserver/pull/12400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org