You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Sergey Beryozkin (JIRA)" <ji...@apache.org> on 2014/08/22 15:40:11 UTC
[jira] [Commented] (CXF-5966) NPE in MessageContextImpl when
setting ResponseBuilder entity in an ExceptionMapper
[ https://issues.apache.org/jira/browse/CXF-5966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106823#comment-14106823 ]
Sergey Beryozkin commented on CXF-5966:
---------------------------------------
This is now fixed, it was caused by the fact that you use a native CXF interceptor and the way the exceptions are mapped to JAX-RS mappers is different, the exceptions flows to a CXF out fault chain where the outMessage is reset to null, and a faultOutMessage is set instead. I've updated the default JAX-RS fault mapper to treat both the same way. In meantime consider using JAXRSBeanValidationInInterceptor and register it as a jaxrs:provider, so it will be treated as a JAX-RS ContainerRequestFilter, this will work for you without waiting for a fix
> NPE in MessageContextImpl when setting ResponseBuilder entity in an ExceptionMapper
> -----------------------------------------------------------------------------------
>
> Key: CXF-5966
> URL: https://issues.apache.org/jira/browse/CXF-5966
> Project: CXF
> Issue Type: Bug
> Components: JAX-RS
> Affects Versions: 3.0.1
> Environment: CXF 3.0.1 with custom ExceptionMapper<ValidationException>, JAXBElementProvider, MessageContextImpl
> Reporter: Matt Parker
> Fix For: 3.0.2, 3.1.0
>
>
> I hope that this description is complete enough. I think creating a test case for this ticket will be more trouble than it's worth, but please let me know if you need me to.
> I have added BeanValidationInInterceptor to my JAX-RS service which uses JAXB-annotated entities.
> I have created an ExceptionMapper to capture and write out the validation errors into my JAXB-annotated object's 'description' field.
> In my exception mapper, I populate MyObject (which is JAXB-annotated), and then set it as the entity:
> responseBuilder.entity(myObject);
> it results in an NPE as the JAXBElementProvider attempts to get any attachments from the MessageContext, which dereferences a null OutboundMessage from its Exchange.
> Line 83 in MessageContextImpl contains:
> {code}
> return m.getExchange().getOutMessage().get(Message.ATTACHMENTS);
> {code}
> The javadoc for Exchange.getOutMessage states that "During the inbound message processing, the outbound message is null".
> {code}
> 2014-08-20 23:50:53,919|ERROR|http-0.0.0.0-8443-2:|STDERR| java.lang.NullPointerException
> 2014-08-20 23:50:53,919|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.ext.MessageContextImpl.get(MessageContextImpl.java:83)
> 2014-08-20 23:50:53,919|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.impl.tl.ThreadLocalMessageContext.get(ThreadLocalMessageContext.java:38)
> 2014-08-20 23:50:53,927|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.provider.JAXBElementProvider.getAttachments(JAXBElementProvider.java:542)
> 2014-08-20 23:50:53,927|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.provider.JAXBElementProvider.addAttachmentMarshaller(JAXBElementProvider.java:520)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.provider.JAXBElementProvider.marshal(JAXBElementProvider.java:444)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.provider.JAXBElementProvider.writeTo(JAXBElementProvider.java:318)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.utils.JAXRSUtils.writeMessageBody(JAXRSUtils.java:1363)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.serializeMessage(JAXRSOutInterceptor.java:244)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.processResponse(JAXRSOutInterceptor.java:117)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.interceptor.JAXRSOutInterceptor.handleMessage(JAXRSOutInterceptor.java:80)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.jaxrs.interceptor.JAXRSDefaultFaultOutInterceptor.handleMessage(JAXRSDefaultFaultOutInterceptor.java:61)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:307)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.interceptor.AbstractFaultChainInitiatorObserver.onMessage(AbstractFaultChainInitiatorObserver.java:113)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.phase.PhaseInterceptorChain.doIntercept(PhaseInterceptorChain.java:371)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.transport.ChainInitiationObserver.onMessage(ChainInitiationObserver.java:121)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.transport.http.AbstractHTTPDestination.invoke(AbstractHTTPDestination.java:243)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.transport.servlet.ServletController.invokeDestination(ServletController.java:223)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:197)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.transport.servlet.ServletController.invoke(ServletController.java:149)
> 2014-08-20 23:50:53,928|ERROR|http-0.0.0.0-8443-2:|STDERR| at org.apache.cxf.transport.servlet.CXFNonSpringServlet.invoke(CXFNonSpringServlet.java:171)
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)