You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Chris Trezzo (JIRA)" <ji...@apache.org> on 2012/09/07 21:03:07 UTC
[jira] [Created] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Chris Trezzo created HBASE-6743:
-----------------------------------
Summary: Move EnvironmentEdge classes to hbase-common
Key: HBASE-6743
URL: https://issues.apache.org/jira/browse/HBASE-6743
Project: HBase
Issue Type: Improvement
Reporter: Chris Trezzo
Assignee: Chris Trezzo
Priority: Minor
Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6743:
--------------------------------
Attachment: 6743v2.txt
Here is an updated patch using git.
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt, 6743v2.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465449#comment-13465449 ]
Hudson commented on HBASE-6743:
-------------------------------
Integrated in HBase-TRUNK #3388 (See [https://builds.apache.org/job/HBase-TRUNK/3388/])
HBASE-6743 Move EnvironmentEdge classes to hbase-common (Revision 1391321)
Result = SUCCESS
stack :
Files :
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt, 6743v2.txt, 6743v3.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451027#comment-13451027 ]
Chris Trezzo commented on HBASE-6743:
-------------------------------------
Yes. Woops. Moving files with svn can be a pain. Will fix. Thanks!
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465531#comment-13465531 ]
Hudson commented on HBASE-6743:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #197 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/197/])
HBASE-6743 Move EnvironmentEdge classes to hbase-common (Revision 1391321)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
* /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
* /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManager.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/EnvironmentEdgeManagerTestHelper.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestEnvironmentEdgeManager.java
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt, 6743v2.txt, 6743v3.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6743:
--------------------------------
Fix Version/s: 0.96.0
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6743:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch Chris.
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt, 6743v2.txt, 6743v3.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6743:
--------------------------------
Status: Patch Available (was: Open)
Trying a HadoopQA run.
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Attachments: 6743v1.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "Chris Trezzo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Trezzo updated HBASE-6743:
--------------------------------
Attachment: 6743v1.txt
Attached a first patch.
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6743:
-------------------------
Attachment: 6743v3.txt
Added the EnvironmentEdge tests and utils too.
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt, 6743v2.txt, 6743v3.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6743) Move EnvironmentEdge classes to
hbase-common
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451006#comment-13451006 ]
stack commented on HBASE-6743:
------------------------------
Did you forget to svn add the classes back in hbase-common Chris? They are not in the patch?
> Move EnvironmentEdge classes to hbase-common
> --------------------------------------------
>
> Key: HBASE-6743
> URL: https://issues.apache.org/jira/browse/HBASE-6743
> Project: HBase
> Issue Type: Improvement
> Reporter: Chris Trezzo
> Assignee: Chris Trezzo
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 6743v1.txt
>
>
> Move the classes related to EnvironmentEdge to the hbase-common module. If we want to replace all occurrences of System.currentTimeMillis() with EnvironmentEdgeManager.currentTimeMillis(), we need to be able to reference these classes from multiple modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira