[GitHub] clintropolis commented on a change in pull request #6107: Order rows during incremental index persist when rollup is disabled.

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #6107: Order rows during incremental index persist when rollup is disabled.
URL: https://github.com/apache/incubator-druid/pull/6107#discussion_r207749482
 
 

 ##########
 File path: processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
 ##########
 @@ -372,6 +374,16 @@ public Builder setSimpleTestingIndexSchema(final AggregatorFactory... metrics)
       return this;
     }
 
+    @VisibleForTesting
+    public Builder setSimpleTestingIndexSchema(boolean rollup, final AggregatorFactory... metrics)
 
 Review comment:
   Sure, though I think I need to change the new method parameter to be `@Nullable Boolean rollup` and check if null to not set `.withRollup` (or not) to preserve the original's intention:
   
   >A helper method to set a simple index schema _with only metrics and default values_ for the other parameters.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org