You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by ct...@apache.org on 2024/10/01 03:39:41 UTC
(accumulo) 02/02: Fix more trivial warnings
This is an automated email from the ASF dual-hosted git repository.
ctubbsii pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/accumulo.git
commit 26b3e4d149ab03589eb6d43fd802383f5bae5e66
Author: Christopher Tubbs <ct...@apache.org>
AuthorDate: Mon Sep 30 18:52:27 2024 -0400
Fix more trivial warnings
* Remove unused log
* Suppress unused private constructors that exist for Gson
---
core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/Bulk.java | 3 +++
core/src/main/java/org/apache/accumulo/core/lock/ServiceLockData.java | 1 +
.../accumulo/core/metadata/schema/ExternalCompactionFinalState.java | 1 +
.../java/org/apache/accumulo/server/metadata/RootGcCandidates.java | 1 +
.../apache/accumulo/server/util/fateCommand/FateSummaryReport.java | 1 +
.../org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java | 1 +
.../accumulo/server/util/serviceStatus/ServiceStatusReport.java | 1 +
.../org/apache/accumulo/server/util/serviceStatus/StatusSummary.java | 1 +
.../main/java/org/apache/accumulo/tserver/log/ResolvedSortedLog.java | 4 ----
9 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/Bulk.java b/core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/Bulk.java
index de178565ae..23f32c4f70 100644
--- a/core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/Bulk.java
+++ b/core/src/main/java/org/apache/accumulo/core/clientImpl/bulk/Bulk.java
@@ -42,6 +42,7 @@ public class Bulk {
private Collection<FileInfo> files;
// Gson requires a default constructor when JDK Unsafe usage is disabled
+ @SuppressWarnings("unused")
private Mapping() {}
public Mapping(KeyExtent tablet, Files files) {
@@ -71,6 +72,7 @@ public class Bulk {
private byte[] prevEndRow;
// Gson requires a default constructor when JDK Unsafe usage is disabled
+ @SuppressWarnings("unused")
private Tablet() {}
public Tablet(Text endRow, Text prevEndRow) {
@@ -111,6 +113,7 @@ public class Bulk {
long estEntries;
// Gson requires a default constructor when JDK Unsafe usage is disabled
+ @SuppressWarnings("unused")
private FileInfo() {}
public FileInfo(String fileName, long estFileSize, long estNumEntries) {
diff --git a/core/src/main/java/org/apache/accumulo/core/lock/ServiceLockData.java b/core/src/main/java/org/apache/accumulo/core/lock/ServiceLockData.java
index ece32eff00..442a6192ce 100644
--- a/core/src/main/java/org/apache/accumulo/core/lock/ServiceLockData.java
+++ b/core/src/main/java/org/apache/accumulo/core/lock/ServiceLockData.java
@@ -242,6 +242,7 @@ public class ServiceLockData implements Comparable<ServiceLockData> {
private String group;
// default constructor required for Gson
+ @SuppressWarnings("unused")
public ServiceDescriptorGson() {}
public ServiceDescriptorGson(UUID uuid, ThriftService service, String address, String group) {
diff --git a/core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionFinalState.java b/core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionFinalState.java
index fb4caa47c3..23902d7f51 100644
--- a/core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionFinalState.java
+++ b/core/src/main/java/org/apache/accumulo/core/metadata/schema/ExternalCompactionFinalState.java
@@ -81,6 +81,7 @@ public class ExternalCompactionFinalState {
String per;
// Gson requires a default constructor
+ @SuppressWarnings("unused")
private Extent() {}
Extent(KeyExtent extent) {
diff --git a/server/base/src/main/java/org/apache/accumulo/server/metadata/RootGcCandidates.java b/server/base/src/main/java/org/apache/accumulo/server/metadata/RootGcCandidates.java
index 7d3ec1b836..4b9fcc7932 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/metadata/RootGcCandidates.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/metadata/RootGcCandidates.java
@@ -53,6 +53,7 @@ public class RootGcCandidates {
private SortedMap<String,SortedSet<String>> candidates;
// Gson requires a default constructor when JDK Unsafe usage is disabled
+ @SuppressWarnings("unused")
private Data() {}
public Data(int version, SortedMap<String,SortedSet<String>> candidates) {
diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateSummaryReport.java b/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateSummaryReport.java
index c3e8990b44..174c70e907 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateSummaryReport.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateSummaryReport.java
@@ -56,6 +56,7 @@ public class FateSummaryReport {
private transient Map<String,String> idsToNameMap;
// Gson requires a default constructor when JDK Unsafe usage is disabled
+ @SuppressWarnings("unused")
private FateSummaryReport() {}
public FateSummaryReport(Map<String,String> idsToNameMap,
diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java b/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java
index 6a1d14bc1d..78904857f1 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/util/fateCommand/FateTxnDetails.java
@@ -39,6 +39,7 @@ public class FateTxnDetails implements Comparable<FateTxnDetails> {
private List<String> locksWaiting = List.of();
// Default constructor for Gson
+ @SuppressWarnings("unused")
private FateTxnDetails() {}
/**
diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/ServiceStatusReport.java b/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/ServiceStatusReport.java
index 629242eecf..b323dbaf77 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/ServiceStatusReport.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/ServiceStatusReport.java
@@ -53,6 +53,7 @@ public class ServiceStatusReport {
private Map<ReportKey,StatusSummary> summaries;
// Gson requires a default constructor when JDK Unsafe usage is disabled
+ @SuppressWarnings("unused")
private ServiceStatusReport() {}
public ServiceStatusReport(final Map<ReportKey,StatusSummary> summaries, final boolean noHosts) {
diff --git a/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/StatusSummary.java b/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/StatusSummary.java
index ec5a044f1a..8c28d012a2 100644
--- a/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/StatusSummary.java
+++ b/server/base/src/main/java/org/apache/accumulo/server/util/serviceStatus/StatusSummary.java
@@ -31,6 +31,7 @@ public class StatusSummary {
private int errorCount;
// Default constructor required for Gson
+ @SuppressWarnings("unused")
private StatusSummary() {}
public StatusSummary(ServiceStatusReport.ReportKey serviceType, final Set<String> resourceGroups,
diff --git a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/ResolvedSortedLog.java b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/ResolvedSortedLog.java
index 184b628ad2..b9faa8c8f7 100644
--- a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/ResolvedSortedLog.java
+++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/ResolvedSortedLog.java
@@ -32,8 +32,6 @@ import org.apache.accumulo.server.manager.recovery.RecoveryPath;
import org.apache.hadoop.fs.FileStatus;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.fs.Path;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
* Write ahead logs have two paths in DFS. There is the path of the original unsorted walog and the
@@ -42,8 +40,6 @@ import org.slf4j.LoggerFactory;
*/
public class ResolvedSortedLog {
- private static final Logger log = LoggerFactory.getLogger(ResolvedSortedLog.class);
-
private final SortedSet<UnreferencedTabletFile> children;
private final LogEntry origin;
private final Path sortedLogDir;