[GitHub] [superset] EugeneTorap commented on a diff in pull request #22925: chore: bump flask-caching and redis

["EugeneTorap (via GitHub)" <gi...@apache.org>]

EugeneTorap commented on code in PR #22925:
URL: https://github.com/apache/superset/pull/22925#discussion_r1097033534


##########
tests/integration_tests/cachekeys/api_tests.py:
##########
@@ -149,9 +149,9 @@ def test_invalidate_existing_caches(invalidate):
     )
 
     assert rv.status_code == 201
-    assert cache_manager.cache.get("cache_key1") is None
-    assert cache_manager.cache.get("cache_key2") is None
-    assert cache_manager.cache.get("cache_key4") is None
+    assert cache_manager.cache.get("cache_key1") == "value"
+    assert cache_manager.cache.get("cache_key2") == "value"
+    assert cache_manager.cache.get("cache_key4") == "value"

Review Comment:
   @dpgaspar @etr2460 @bkyryliuk  @Antonio-RiveroMartnez @Yoann-tildev Do you know why this `cache_manager` behavior has changed in new version of `flask-caching`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org