You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2019/10/10 06:33:56 UTC

Re: Review Request 71554: RANGER-2595: Improve policy delete performance using batch delete

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71554/#review218172
-----------------------------------------------------------


Ship it!




Ship It!

- Nikhil P


On Sept. 29, 2019, 11:43 a.m., Andrew Luo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71554/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2019, 11:43 a.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2595
>     https://issues.apache.org/jira/browse/RANGER-2595
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Policy deletion is slow for policies that have a large number of users or resources.  This patch uses batch SQL deletion to speed up deletion.
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java 055cd382b 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java 1ef01bb28 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefConditionDao.java 2c04ab483 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefDataMaskTypeDao.java 258e3b0ba 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefGroupDao.java 08829d4f7 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefResourceDao.java e259ee864 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefRoleDao.java b92f8066f 
>   security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefUserDao.java f7b6131c6 
>   security-admin/src/main/resources/META-INF/jpa_named_queries.xml 9714fa91b 
> 
> 
> Diff: https://reviews.apache.org/r/71554/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually, ran build/tests
> 
> 
> Thanks,
> 
> Andrew Luo
> 
>