You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/01/30 17:36:21 UTC

[GitHub] piyushghai commented on a change in pull request #14020: Fix jar path and add missing ones for spark jobs

piyushghai commented on a change in pull request #14020: Fix jar path and add missing ones for spark jobs
URL: https://github.com/apache/incubator-mxnet/pull/14020#discussion_r252361658
 
 

 ##########
 File path: scala-package/spark/src/test/scala/org/apache/mxnet/spark/SharedSparkContext.scala
 ##########
 @@ -81,17 +81,15 @@ trait SharedSparkContext extends FunSuite with BeforeAndAfterEach with BeforeAnd
   }
 
   private def getJarFilePath(root: String): String = {
-    for (platform <- List("linux-x86_64-cpu", "linux-x86_64-gpu", "osx-x86_64-cpu")) {
 
 Review comment:
   Yes. The path for the jars is platform agnostic now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services