[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl

[GitBox <gi...@apache.org>]

zrhoffman commented on a change in pull request #4247: TO image: Copy files from a previous build stage instead of trafficops-perl
URL: https://github.com/apache/trafficcontrol/pull/4247#discussion_r362638909
 
 

 ##########
 File path: infrastructure/cdn-in-a-box/docker-compose.yml
 ##########
 @@ -58,8 +58,10 @@ services:
   # defined below
   trafficops:
     build:
-      context: .
-      dockerfile: traffic_ops/Dockerfile-go
+      context: ../..
 
 Review comment:
   The `trafficops` and `trafficops-perl` containers both receive a build arg named `TRAFFIC_OPS_RPM`. IMO, both of these build args should be the same value. That means that `trafficops` needs `infrastructure/cdn-in-a-box` in its build context in order to successfully be able to run its `COPY` command.
   
   Within the constraints discussed, in order to only specify the build arg once, it would be possible for `trafficops-go` and `trafficops-perl` to both be child images of a `centos:7` image that does nothing else but receive the `TRAFFIC_OPS_RPM` build arg and export it as an environment variable. However, in this case, the `trafficops` container would still require a build context that includes `infrastructure/cdn-in-a-box`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services