[GitHub] [fineract] galovics commented on pull request #3124: FINERACT-1724-Regular-loan-cob-job-having-catch-up-true-catchup-api

["galovics (via GitHub)" <gi...@apache.org>]

galovics commented on PR #3124:
URL: https://github.com/apache/fineract/pull/3124#issuecomment-1508495906

   I'm not sure about the query changes you've made @ruchiD but I don't see any migration script to handle existing data.
   If the DB column says its a json, let's enforce and have properly formatted JSONs in the column.
   
   I see there are 3 types of data stored in that column:
   - `[{ "parameterName": "BusinessDate", "parameterValue": "2023-04-13"}]`
   - `[1, 2, 3, 4, 5]`
   - `"2023-04-13"`
   
   The last one is obviously not even conforming the JSON syntax, let's migrate them to:
   `[{ "parameterName": "SomeOtherDate", "parameterValue": "2023-04-13"}]`
   
   The middle one with the IDs should also be conforming the above structure:
   `[{ "parameterName": "loanIdsOrSomething", "parameterValue": [1, 2, 3, 4, 5]}]`
   
   Obviously the part where saving and reading this data should be changed accordingly but the intention was to have this parameterName/parameterValue pairs in every row.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org