You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Stephen Moist <mo...@cloudera.com.INVALID> on 2018/09/25 16:30:13 UTC
Migrating existing loggers to Lombok
Hey all, with Sentry-2374, we’ve introduced Lombok to create our loggers in the SPI portion of Sentry. For consistency’s sake, we should migrate the existing Sentry code to use the Lombok annotations instead of using the existing logger.getLogger(class). I see 2 ways of doing it. 1) As classes are modified, add in the annotation and remove the existing logger. 2) Create an epic in Jira, create tasks under it for each maven module, then go through all the classes in each module and convert to it.
I don’t think this is critical or time sensitive to do, but it should be more of a code cleanup task than anything else that we can do over the next few months. Thoughts on this?
Re: Migrating existing loggers to Lombok
Posted by Na Li <li...@cloudera.com.INVALID>.
Option 1 works for me
Sent from my iPhone
> On Sep 27, 2018, at 1:04 PM, Brian Towles <bt...@cloudera.com.INVALID> wrote:
>
> I feel that since this doesn't really provide any difference in
> functionality, just only a change to how the LOGGER variable gets defined
> and initialized, that it doesn't have to be an in mass change and can be
> done in an incremental and as needed fashion.
>
> On Tue, Sep 25, 2018 at 1:54 PM Kalyan Kumar Kalvagadda
> <kk...@cloudera.com.invalid> wrote:
>
>> I prefer option-1. Changing complete code involves change a ton of class.
>> It's a huge effort. Even if you take option-2 if would take a very only
>> time to change all the classes. Let's be practical.
>>
>>
>> *Thanks,Kalyan Kumar Kalvagadda* | Software Engineer
>> t. (469) 279- <0000000000>5732
>> cloudera.com <https://www.cloudera.com>
>>
>> [image: Cloudera] <https://www.cloudera.com/>
>>
>> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
>> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
>> on LinkedIn] <https://www.linkedin.com/company/cloudera>
>> ------------------------------
>>
>>
>> On Tue, Sep 25, 2018 at 1:49 PM Na Li <li...@cloudera.com.invalid>
>> wrote:
>>
>>> Stephen,
>>>
>>> I prefer option 2), so our code can be more consistent.
>>>
>>> Thanks,
>>>
>>> Lina
>>>
>>> On Tue, Sep 25, 2018 at 11:30 AM Stephen Moist
>> <moist@cloudera.com.invalid
>>>>
>>> wrote:
>>>
>>>> Hey all, with Sentry-2374, we’ve introduced Lombok to create our
>> loggers
>>>> in the SPI portion of Sentry. For consistency’s sake, we should
>> migrate
>>>> the existing Sentry code to use the Lombok annotations instead of using
>>> the
>>>> existing logger.getLogger(class). I see 2 ways of doing it. 1) As
>>> classes
>>>> are modified, add in the annotation and remove the existing logger. 2)
>>>> Create an epic in Jira, create tasks under it for each maven module,
>> then
>>>> go through all the classes in each module and convert to it.
>>>>
>>>> I don’t think this is critical or time sensitive to do, but it should
>> be
>>>> more of a code cleanup task than anything else that we can do over the
>>> next
>>>> few months. Thoughts on this?
>>>
>>
> --
> *Brian Towles* | Software Engineer
> t. (512) 415- <0000000000>8105 e. btowles@cloudera.com <jo...@cloudera.com>
> cloudera.com <http://www.cloudera.com/>
>
> [image: Cloudera] <http://www.cloudera.com/>
>
> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
> on LinkedIn] <https://www.linkedin.com/company/cloudera>
> ------------------------------
Re: Migrating existing loggers to Lombok
Posted by Brian Towles <bt...@cloudera.com.INVALID>.
I feel that since this doesn't really provide any difference in
functionality, just only a change to how the LOGGER variable gets defined
and initialized, that it doesn't have to be an in mass change and can be
done in an incremental and as needed fashion.
On Tue, Sep 25, 2018 at 1:54 PM Kalyan Kumar Kalvagadda
<kk...@cloudera.com.invalid> wrote:
> I prefer option-1. Changing complete code involves change a ton of class.
> It's a huge effort. Even if you take option-2 if would take a very only
> time to change all the classes. Let's be practical.
>
>
> *Thanks,Kalyan Kumar Kalvagadda* | Software Engineer
> t. (469) 279- <0000000000>5732
> cloudera.com <https://www.cloudera.com>
>
> [image: Cloudera] <https://www.cloudera.com/>
>
> [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
> Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
> on LinkedIn] <https://www.linkedin.com/company/cloudera>
> ------------------------------
>
>
> On Tue, Sep 25, 2018 at 1:49 PM Na Li <li...@cloudera.com.invalid>
> wrote:
>
> > Stephen,
> >
> > I prefer option 2), so our code can be more consistent.
> >
> > Thanks,
> >
> > Lina
> >
> > On Tue, Sep 25, 2018 at 11:30 AM Stephen Moist
> <moist@cloudera.com.invalid
> > >
> > wrote:
> >
> > > Hey all, with Sentry-2374, we’ve introduced Lombok to create our
> loggers
> > > in the SPI portion of Sentry. For consistency’s sake, we should
> migrate
> > > the existing Sentry code to use the Lombok annotations instead of using
> > the
> > > existing logger.getLogger(class). I see 2 ways of doing it. 1) As
> > classes
> > > are modified, add in the annotation and remove the existing logger. 2)
> > > Create an epic in Jira, create tasks under it for each maven module,
> then
> > > go through all the classes in each module and convert to it.
> > >
> > > I don’t think this is critical or time sensitive to do, but it should
> be
> > > more of a code cleanup task than anything else that we can do over the
> > next
> > > few months. Thoughts on this?
> >
>
--
*Brian Towles* | Software Engineer
t. (512) 415- <0000000000>8105 e. btowles@cloudera.com <jo...@cloudera.com>
cloudera.com <http://www.cloudera.com/>
[image: Cloudera] <http://www.cloudera.com/>
[image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
on LinkedIn] <https://www.linkedin.com/company/cloudera>
------------------------------
Re: Migrating existing loggers to Lombok
Posted by Kalyan Kumar Kalvagadda <kk...@cloudera.com.INVALID>.
I prefer option-1. Changing complete code involves change a ton of class.
It's a huge effort. Even if you take option-2 if would take a very only
time to change all the classes. Let's be practical.
*Thanks,Kalyan Kumar Kalvagadda* | Software Engineer
t. (469) 279- <0000000000>5732
cloudera.com <https://www.cloudera.com>
[image: Cloudera] <https://www.cloudera.com/>
[image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
on LinkedIn] <https://www.linkedin.com/company/cloudera>
------------------------------
On Tue, Sep 25, 2018 at 1:49 PM Na Li <li...@cloudera.com.invalid> wrote:
> Stephen,
>
> I prefer option 2), so our code can be more consistent.
>
> Thanks,
>
> Lina
>
> On Tue, Sep 25, 2018 at 11:30 AM Stephen Moist <moist@cloudera.com.invalid
> >
> wrote:
>
> > Hey all, with Sentry-2374, we’ve introduced Lombok to create our loggers
> > in the SPI portion of Sentry. For consistency’s sake, we should migrate
> > the existing Sentry code to use the Lombok annotations instead of using
> the
> > existing logger.getLogger(class). I see 2 ways of doing it. 1) As
> classes
> > are modified, add in the annotation and remove the existing logger. 2)
> > Create an epic in Jira, create tasks under it for each maven module, then
> > go through all the classes in each module and convert to it.
> >
> > I don’t think this is critical or time sensitive to do, but it should be
> > more of a code cleanup task than anything else that we can do over the
> next
> > few months. Thoughts on this?
>
Re: Migrating existing loggers to Lombok
Posted by Na Li <li...@cloudera.com.INVALID>.
Stephen,
I prefer option 2), so our code can be more consistent.
Thanks,
Lina
On Tue, Sep 25, 2018 at 11:30 AM Stephen Moist <mo...@cloudera.com.invalid>
wrote:
> Hey all, with Sentry-2374, we’ve introduced Lombok to create our loggers
> in the SPI portion of Sentry. For consistency’s sake, we should migrate
> the existing Sentry code to use the Lombok annotations instead of using the
> existing logger.getLogger(class). I see 2 ways of doing it. 1) As classes
> are modified, add in the annotation and remove the existing logger. 2)
> Create an epic in Jira, create tasks under it for each maven module, then
> go through all the classes in each module and convert to it.
>
> I don’t think this is critical or time sensitive to do, but it should be
> more of a code cleanup task than anything else that we can do over the next
> few months. Thoughts on this?