You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ni...@apache.org on 2011/03/04 22:09:03 UTC
svn commit: r1078135 - in /poi/trunk:
src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
test-data/spreadsheet/50833.xls
Author: nick
Date: Fri Mar 4 21:09:02 2011
New Revision: 1078135
URL: http://svn.apache.org/viewvc?rev=1078135&view=rev
Log:
Add a unit test for bug #50833
Added:
poi/trunk/test-data/spreadsheet/50833.xls (with props)
Modified:
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java?rev=1078135&r1=1078134&r2=1078135&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestBugs.java Fri Mar 4 21:09:02 2011
@@ -22,7 +22,10 @@ import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Iterator;
+import java.util.List;
import junit.framework.AssertionFailedError;
@@ -43,7 +46,6 @@ import org.apache.poi.ss.formula.ptg.Ptg
import org.apache.poi.ss.usermodel.BaseTestBugzillaIssues;
import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.CellStyle;
-import org.apache.poi.ss.usermodel.DataFormatter;
import org.apache.poi.ss.usermodel.Name;
import org.apache.poi.ss.usermodel.Row;
import org.apache.poi.ss.usermodel.Sheet;
@@ -1983,4 +1985,38 @@ if(1==2) {
assertEquals("35", df.formatCellValue(r18.getCell(2)));
assertEquals("123", df.formatCellValue(r18.getCell(3)));
}
+
+ /**
+ * A protected sheet with comments, when written out by
+ * POI, ends up upsetting excel.
+ * TODO Identify the cause and add extra asserts for
+ * the bit excel cares about
+ */
+ public void test50833() throws Exception {
+ HSSFWorkbook wb = openSample("50833.xls");
+ HSSFSheet s = wb.getSheetAt(0);
+ assertEquals("Sheet1", s.getSheetName());
+ assertEquals(false, s.getProtect());
+
+ HSSFCell c = s.getRow(0).getCell(0);
+ assertEquals("test cell value", c.getRichStringCellValue().getString());
+
+ HSSFComment cmt = c.getCellComment();
+ assertNotNull(cmt);
+ assertEquals("Robert Lawrence", cmt.getAuthor());
+ assertEquals("Robert Lawrence:\ntest comment", cmt.getString().getString());
+
+ // Reload
+ wb = writeOutAndReadBack(wb);
+ s = wb.getSheetAt(0);
+ c = s.getRow(0).getCell(0);
+
+ // Re-check the comment
+ cmt = c.getCellComment();
+ assertNotNull(cmt);
+ assertEquals("Robert Lawrence", cmt.getAuthor());
+ assertEquals("Robert Lawrence:\ntest comment", cmt.getString().getString());
+
+ // TODO Identify what excel doesn't like, and check for that
+ }
}
Added: poi/trunk/test-data/spreadsheet/50833.xls
URL: http://svn.apache.org/viewvc/poi/trunk/test-data/spreadsheet/50833.xls?rev=1078135&view=auto
==============================================================================
Binary file - no diff available.
Propchange: poi/trunk/test-data/spreadsheet/50833.xls
------------------------------------------------------------------------------
svn:mime-type = application/octet-stream
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org