[GitHub] [airflow] mik-laj edited a comment on pull request #10368: CI Images are now pre-build and stored in registry

[GitBox <gi...@apache.org>]

mik-laj edited a comment on pull request #10368:
URL: https://github.com/apache/airflow/pull/10368#issuecomment-675196719


   This change is huge. What can we reduce its size? I can see a few changes that we can extract and do as a separate change:
   * merging to ``--github-organisation`` and ``--github-repo`` flags into ``--github-repository`` 
   * building documentation and spell checking separately,.
   * renaming `ci_*..sh` scripts 
   * pylint fixes in ``docs/build_docs.py``
   * renaming variable in ``scripts/ci/in_container/run_prepare_backport_readme.sh``, ``scripts/ci/in_container/run_test_package_import_all_classes.sh``
   * less verbose output from helm,kubectl - scripts/ci/libraries/_verbosity.sh
   * pyllint fixes in ``scripts/tools/list-integrations.py``.
   
   This may seem like a lot of extra work, but I think it's the only way we can be sure about this change and not get a lot of teething problems. Now it is very painful for me to review this change because I have to remember every change and think about the consequences of many changes at once. 
   
   If you like, I will be happy to help you break down this change to make it easier to review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org