You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/23 20:24:54 UTC

[GitHub] [tvm] tqchen commented on a change in pull request #7153: [RUNTIME] Add libbacktrace for backtraces with line numbers

tqchen commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r548206504



##########
File path: include/tvm/ir/attrs.h
##########
@@ -393,7 +392,7 @@ struct AttrInitEntry {
     value_missing_ = false;
     return *this;
   }
-  TSelf& describe(DMLC_ATTRIBUTE_UNUSED const char* str) { return *this; }
+  TSelf& describe(__attribute__((unused)) const char* str) { return *this; }

Review comment:
       Thanks @tkonolige for the intitial POC. Given the amount of refactoring needed, which we did not anticipate in the beginning. Let us discuss a bit more about possible alternatives a good resolution before proceeding with this PR.
   
   A generic marco is needed in most of these cases for cross platform reasons(MSVC support




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org