[GitHub] [iceberg] rdblue commented on a diff in pull request #6170: Python: Move FileIO initialization to the catalog

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #6170:
URL: https://github.com/apache/iceberg/pull/6170#discussion_r1019421535


##########
python/pyiceberg/catalog/__init__.py:
##########
@@ -162,6 +163,9 @@ def __init__(self, name: str, **properties: str):
         self.name = name
         self.properties = properties
 
+    def _load_file_io(self, properties: Properties = EMPTY_DICT) -> FileIO:
+        return load_file_io({**self.properties, **properties})

Review Comment:
   I don't think that we include table properties in the JVM version, but this seems like a good idea to me!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org