[GitHub] [pulsar] aloyszhang commented on pull request #21025: [fix][broker] fix UniformLoadShedder selecet wrong overloadbroker and underloadbroker

["aloyszhang (via GitHub)" <gi...@apache.org>]

aloyszhang commented on PR #21025:
URL: https://github.com/apache/pulsar/pull/21025#issuecomment-1683857603

   <img width="1578" alt="image" src="https://github.com/apache/pulsar/assets/48062889/68120a04-439e-4e8c-b315-1752217b73d4">
   Test with three 
   - 3 brokers
   - 6 topics, each one has 11 partitions, topics have different msgRates and msgSizes
   
   At 16:52 start load-balance with this fix and the following parameters:
   - loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold=1.3
   - loadBalancerMsgRateDifferenceShedderThreshold=0 (disable)
   
   We can see all brokers are balanced well based on throughput.
   At 17:04 modify loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold from 1.3 to 1.05
   All brokers load are more balanced.
   
   Then fallback server to origin UniformLoadShedder(without this fix) and restart broker at 17:15, all configurations are not modified:
   - loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold=1.05
   - loadBalancerMsgRateDifferenceShedderThreshold=0 (disable)
   Brokers load  balanced at 17:24, but it's not quite balanced, maxThroughput is 128MB/s and minThroughput is 88 MB/s, the finnaly loadDifferent is 128/88 = 1.45 which is bigger than loadBalancerMsgThroughputMultiplierDifferenceShedderThreshold(1.05)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org