[jira] [Commented] (HIVE-15873) Remove Windows-specific code

["Hive QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-15873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15860808#comment-15860808 ] 

Hive QA commented on HIVE-15873:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12851976/HIVE-15873.2.patch

{color:green}SUCCESS:{color} +1 due to 28 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10232 tests executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223)
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfDefault (batchId=188)
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfDefaultEmptyString (batchId=188)
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfOverridden (batchId=188)
org.apache.hadoop.hive.metastore.TestHiveMetaStoreGetMetaConf.testGetMetaConfUnknownPreperty (batchId=188)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3481/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3481/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3481/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12851976 - PreCommit-HIVE-Build

> Remove Windows-specific code
> ----------------------------
>
>                 Key: HIVE-15873
>                 URL: https://issues.apache.org/jira/browse/HIVE-15873
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>         Attachments: HIVE-15873.1.patch, HIVE-15873.2.patch
>
>
> I know a lot of work has gone initially into supporting UT, runtime, etc on Windows, but this code seems to have been rotting. 
> There have been no updates to the windows specific test files, or any new code to keep the new features compatible.
> We're also not running the tests or builds on windows. That is really an impediment to keepting that code healthy.
> The code is sprinkled all over the codebase. Makes it hard to maintain. I think we're better off removing it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)