[jira] [Comment Edited] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)

["Aditya Sharma (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129082#comment-17129082 ] 

Aditya Sharma edited comment on OFBIZ-11304 at 6/9/20, 9:58 AM:
----------------------------------------------------------------

Thanks Jacques.
 I will take care of sharing on dev ML thread.

Also, I have removed the custom task checkstyleChanged as checkstyleMain fulfilled the requirement.

[https://github.com/apache/ofbiz-framework/pull/161/files]


was (Author: aditya.sharma):
Thanks Jacques.
 I will take care of sharing on dev ML thread.

Also, I have removed the custom task checkstyleChanged as it checkstyleMain fulfilled the requirement.

https://github.com/apache/ofbiz-framework/pull/161/files

> Install a Checkstyle pre-push (on every committer machine?)
> -----------------------------------------------------------
>
>                 Key: OFBIZ-11304
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-11304
>             Project: OFBiz
>          Issue Type: Sub-task
>    Affects Versions: Trunk
>            Reporter: Jacques Le Roux
>            Priority: Minor
>             Fix For: Upcoming Branch
>
>
> The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by the check gradle task. It's "hard" to exactly know from where lint errors  come among all still present.
> I think we should rely on a Checkstyle pre-commit hook like https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when a lint error is present in the commit. 
> Every committer would have it installed locally and the problem would be gone with some committers good will. I started a discussion about it at https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3



--
This message was sent by Atlassian Jira
(v8.3.4#803005)